Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2538093003: Prep to remove API-related #defines from voice_engine_configurations.h (Closed)

Created:
4 years ago by hlundin-webrtc
Modified:
4 years ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Prep to remove API-related #defines from voice_engine_configurations.h The follwing #defines are marked as deprecated: - WEBRTC_VOICE_ENGINE_VOLUME_CONTROL_API - WEBRTC_VOICE_ENGINE_VIDEO_SYNC_API - WEBRTC_VOICE_ENGINE_RTP_RTCP_API - WEBRTC_VOICE_ENGINE_NETEQ_STATS_API - WEBRTC_VOICE_ENGINE_HARDWARE_API - WEBRTC_VOICE_ENGINE_FILE_API - WEBRTC_VOICE_ENGINE_EXTERNAL_MEDIA_API - WEBRTC_VOICE_ENGINE_CODEC_API - WEBRTC_VOICE_ENGINE_AUDIO_PROCESSING_API BUG=webrtc:6506 Committed: https://crrev.com/06c1d6484ea4c445f5db7d90889d5839e03d59e6 Cr-Commit-Position: refs/heads/master@{#15341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -0 lines) Patch
M webrtc/voice_engine/test/auto_test/voe_standard_test.h View 1 chunk +28 lines, -0 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_test_defines.h View 1 chunk +28 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voe_audio_processing_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voe_codec_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voe_external_media_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voe_file_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voe_hardware_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voe_neteq_stats_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voe_rtp_rtcp_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voe_video_sync_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voe_volume_control_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voice_engine_impl.h View 1 chunk +28 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2530373002 Patch 1

Messages

Total messages: 9 (4 generated)
hlundin-webrtc
solenberg, PTAL.
4 years ago (2016-11-30 14:19:10 UTC) #2
the sun
lgtm
4 years ago (2016-11-30 14:28:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2538093003/1
4 years ago (2016-11-30 16:05:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 16:21:53 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-30 16:22:00 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/06c1d6484ea4c445f5db7d90889d5839e03d59e6
Cr-Commit-Position: refs/heads/master@{#15341}

Powered by Google App Engine
This is Rietveld 408576698