Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2530373002: Remove 3 defines in voice_engine_configurations.h (Closed)

Created:
4 years ago by hlundin-webrtc
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), henrika_webrtc, Andrew MacDonald, qiang.lu, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, niklas.enbom, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove 3 defines in voice_engine_configurations.h WEBRTC_VOICE_ENGINE_AGC, WEBRTC_VOICE_ENGINE_ECHO, and WEBRTC_VOICE_ENGINE_NR are now gone. BUG=webrtc:6506 Committed: https://crrev.com/097529f34cd029f8e8dcb8d2700feef9c6c5b02b Cr-Commit-Position: refs/heads/master@{#15309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -102 lines) Patch
M webrtc/voice_engine/voe_audio_processing_impl.cc View 18 chunks +0 lines, -98 lines 0 comments Download
M webrtc/voice_engine_configurations.h View 1 chunk +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
hlundin-webrtc
solenberg: PTAL tina: Please, review voice_engine_configurations.h
4 years ago (2016-11-28 10:36:05 UTC) #2
the sun
lgtm
4 years ago (2016-11-28 12:57:00 UTC) #3
tlegrand-webrtc
lgtm
4 years ago (2016-11-30 07:32:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2530373002/1
4 years ago (2016-11-30 07:49:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 08:12:53 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-30 08:13:00 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/097529f34cd029f8e8dcb8d2700feef9c6c5b02b
Cr-Commit-Position: refs/heads/master@{#15309}

Powered by Google App Engine
This is Rietveld 408576698