Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2536653002: Update video histograms that do not have a minimum lifetime limit before being recorded. (Closed)

Created:
4 years ago by åsapersson
Modified:
4 years ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update video histograms that do not have a minimum lifetime limit before being recorded. Updated histograms: "WebRTC.Video.ReceivedPacketsLostInPercent" (two RTCP RR previously needed) "WebRTC.Video.ReceivedFecPacketsInPercent" (one received packet previously needed) "WebRTC.Video.RecoveredMediaPacketsInPercentOfFec" (one received FEC packet previously needed) Prevents logging stats if call was shortly in use. BUG=b/32659204 Committed: https://crrev.com/0c43f779f8ed38e02fd8bf7bef6f8bf15e8f1aad Cr-Commit-Position: refs/heads/master@{#15315}

Patch Set 1 : Split from https://codereview.webrtc.org/2482763003/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -7 lines) Patch
M webrtc/modules/rtp_rtcp/include/ulpfec_receiver.h View 1 chunk +5 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/ulpfec_receiver_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/ulpfec_receiver_unittest.cc View 2 chunks +13 lines, -1 line 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 3 chunks +14 lines, -5 lines 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 2 chunks +59 lines, -0 lines 0 comments Download
M webrtc/video/rtp_stream_receiver.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
åsapersson
4 years ago (2016-11-28 14:36:44 UTC) #12
stefan-webrtc
lgtm
4 years ago (2016-11-29 18:01:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2536653002/20001
4 years ago (2016-11-30 09:07:07 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-11-30 09:42:31 UTC) #18
commit-bot: I haz the power
4 years ago (2016-11-30 09:42:38 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c43f779f8ed38e02fd8bf7bef6f8bf15e8f1aad
Cr-Commit-Position: refs/heads/master@{#15315}

Powered by Google App Engine
This is Rietveld 408576698