Update video histograms that do not have a minimum lifetime limit before being recorded.

webrtc/video/receive_statistics_proxy_unittest.cc

 /*
  *  Copyright 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/video/receive_statistics_proxy.h"
 
 #include <memory>
 
+#include "webrtc/system_wrappers/include/metrics.h"
 #include "webrtc/system_wrappers/include/metrics_default.h"
 #include "webrtc/test/gtest.h"
 
 namespace webrtc {
 namespace {
 const int64_t kFreqOffsetProcessIntervalInMs = 40000;
 const uint32_t kLocalSsrc = 123;
 const uint32_t kRemoteSsrc = 456;
 const int kMinRequiredSamples = 200;
 }  // namespace
@@ skipping 80 matching lines @@
   const int64_t kTimeSec = 3;
   fake_clock_.AdvanceTimeMilliseconds(kTimeSec * 1000);
   // Histograms are updated when the statistics_proxy_ is deleted.
   statistics_proxy_.reset();
   EXPECT_EQ(1,
             metrics::NumSamples("WebRTC.Video.ReceiveStreamLifetimeInSeconds"));
   EXPECT_EQ(1, metrics::NumEvents("WebRTC.Video.ReceiveStreamLifetimeInSeconds",
                                   kTimeSec));
 }
 
+TEST_F(ReceiveStatisticsProxyTest, PacketLossHistogramIsUpdated) {
+  const uint32_t kCumLost1 = 1;
+  const uint32_t kExtSeqNum1 = 10;
+  const uint32_t kCumLost2 = 2;
+  const uint32_t kExtSeqNum2 = 20;
+
+  // One report block received.
+  RtcpStatistics rtcp_stats1;
+  rtcp_stats1.cumulative_lost = kCumLost1;
+  rtcp_stats1.extended_max_sequence_number = kExtSeqNum1;
+  statistics_proxy_->StatisticsUpdated(rtcp_stats1, kRemoteSsrc);
+
+  // Two report blocks received.
+  RtcpStatistics rtcp_stats2;
+  rtcp_stats2.cumulative_lost = kCumLost2;
+  rtcp_stats2.extended_max_sequence_number = kExtSeqNum2;
+  statistics_proxy_->StatisticsUpdated(rtcp_stats2, kRemoteSsrc);
+
+  // Two received report blocks but min run time has not passed.
+  fake_clock_.AdvanceTimeMilliseconds(metrics::kMinRunTimeInSeconds * 1000 - 1);
+  SetUp();  // Reset stat proxy causes histograms to be updated.
+  EXPECT_EQ(0,
+            metrics::NumSamples("WebRTC.Video.ReceivedPacketsLostInPercent"));
+
+  // Two report blocks received.
+  statistics_proxy_->StatisticsUpdated(rtcp_stats1, kRemoteSsrc);
+  statistics_proxy_->StatisticsUpdated(rtcp_stats2, kRemoteSsrc);
+
+  // Two received report blocks and min run time has passed.
+  fake_clock_.AdvanceTimeMilliseconds(metrics::kMinRunTimeInSeconds * 1000);
+  SetUp();
+  EXPECT_EQ(1,
+            metrics::NumSamples("WebRTC.Video.ReceivedPacketsLostInPercent"));
+  EXPECT_EQ(1, metrics::NumEvents("WebRTC.Video.ReceivedPacketsLostInPercent",
+                                  (kCumLost2 - kCumLost1) * 100 /
+                                      (kExtSeqNum2 - kExtSeqNum1)));
+}
+
+TEST_F(ReceiveStatisticsProxyTest,
+       PacketLossHistogramIsNotUpdatedIfLessThanTwoReportBlocksAreReceived) {
+  RtcpStatistics rtcp_stats1;
+  rtcp_stats1.cumulative_lost = 1;
+  rtcp_stats1.extended_max_sequence_number = 10;
+
+  // Min run time has passed but no received report block.
+  fake_clock_.AdvanceTimeMilliseconds(metrics::kMinRunTimeInSeconds * 1000);
+  SetUp();  // Reset stat proxy causes histograms to be updated.
+  EXPECT_EQ(0,
+            metrics::NumSamples("WebRTC.Video.ReceivedPacketsLostInPercent"));
+
+  // Min run time has passed but only one received report block.
+  statistics_proxy_->StatisticsUpdated(rtcp_stats1, kRemoteSsrc);
+  fake_clock_.AdvanceTimeMilliseconds(metrics::kMinRunTimeInSeconds * 1000);
+  SetUp();
+  EXPECT_EQ(0,
+            metrics::NumSamples("WebRTC.Video.ReceivedPacketsLostInPercent"));
+}
+
 TEST_F(ReceiveStatisticsProxyTest, AvSyncOffsetHistogramIsUpdated) {
   const int64_t kSyncOffsetMs = 22;
   const double kFreqKhz = 90.0;
   for (int i = 0; i < kMinRequiredSamples; ++i)
     statistics_proxy_->OnSyncOffsetUpdated(kSyncOffsetMs, kFreqKhz);
   // Histograms are updated when the statistics_proxy_ is deleted.
   statistics_proxy_.reset();
   EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.AVSyncOffsetInMs"));
   EXPECT_EQ(1,
             metrics::NumEvents("WebRTC.Video.AVSyncOffsetInMs", kSyncOffsetMs));
@@ skipping 12 matching lines @@
   fake_clock_.AdvanceTimeMilliseconds(kFreqOffsetProcessIntervalInMs);
   // Process interval passed, max diff: 4.
   statistics_proxy_->OnSyncOffsetUpdated(kSyncOffsetMs, kFreqKhz);
   statistics_proxy_.reset();
   // Average reported: (2 + 4) / 2 = 3.
   EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.RtpToNtpFreqOffsetInKhz"));
   EXPECT_EQ(1, metrics::NumEvents("WebRTC.Video.RtpToNtpFreqOffsetInKhz", 3));
 }
 
 }  // namespace webrtc