webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc - Issue 2535593002: RTC_[D]CHECK_op: Remove "u" suffix on integer constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc

Issue 2535593002: RTC_[D]CHECK_op: Remove "u" suffix on integer constants (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc

index cdb45b0d5f59bb39ce14fa065fcbed097c9f5345..494c8708f1179824eb7bcf547f9aa92fb5273ae0 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc

@@ -101,7 +101,7 @@ bool Bye::Create(uint8_t* packet,

*index += reason_length;

// Add padding bytes if needed.

size_t bytes_to_pad = index_end - *index;

- RTC_DCHECK_LE(bytes_to_pad, 3u);

+ RTC_DCHECK_LE(bytes_to_pad, 3);

if (bytes_to_pad > 0) {

memset(&packet[*index], 0, bytes_to_pad);

*index += bytes_to_pad;