Fix memory leak in video_coding::PacketBuffer::InsertPacket.

webrtc/modules/video_coding/packet_buffer.h

Index: webrtc/modules/video_coding/packet_buffer.h
diff --git a/webrtc/modules/video_coding/packet_buffer.h b/webrtc/modules/video_coding/packet_buffer.h
index 36b302715858b584a5d9f7922b70e125e022fa59..9aa3db11c85cfcfc7ca0cd77e2094761030c922d 100644
--- a/webrtc/modules/video_coding/packet_buffer.h
+++ b/webrtc/modules/video_coding/packet_buffer.h
@@ -50,7 +50,7 @@ class PacketBuffer {
 
   // Returns true if |packet| is inserted into the packet buffer,
   // false otherwise. Made virtual for testing.
-  virtual bool InsertPacket(const VCMPacket& packet);
+  virtual bool InsertPacket(VCMPacket* packet);

[nisse-webrtc, 2016/11/29 12:31:40]

Please comment on the ownership convention. As far as I understand the current
code, you take ownership of the packet->dataPtr storage, but not of the storage
of the VCMPacket object itself? Which is still a bit confusing.

[philipel, 2016/11/29 12:40:23]

Done.

   void ClearTo(uint16_t seq_num);
   void Clear();