Fix memory leak in video_coding::PacketBuffer::InsertPacket.

webrtc/modules/video_coding/packet_buffer.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 32 matching lines @@
   static rtc::scoped_refptr<PacketBuffer> Create(
       Clock* clock,
       size_t start_buffer_size,
       size_t max_buffer_size,
       OnReceivedFrameCallback* frame_callback);
 
   virtual ~PacketBuffer();
 
   // Returns true if |packet| is inserted into the packet buffer,
   // false otherwise. Made virtual for testing.
-  virtual bool InsertPacket(const VCMPacket& packet);
+  virtual bool InsertPacket(VCMPacket* packet);

[nisse-webrtc, 2016/11/29 12:31:40]

Please comment on the ownership convention. As far as I understand the current
code, you take ownership of the packet->dataPtr storage, but not of the storage
of the VCMPacket object itself? Which is still a bit confusing.

[philipel, 2016/11/29 12:40:23]

Done.

   void ClearTo(uint16_t seq_num);
   void Clear();
 
   int AddRef() const;
   int Release() const;
 
  protected:
   // Both |start_buffer_size| and |max_buffer_size| must be a power of 2.
   PacketBuffer(Clock* clock,
                size_t start_buffer_size,
@@ skipping 80 matching lines @@
   // Called when a received frame is found.
   OnReceivedFrameCallback* const received_frame_callback_;
 
   mutable volatile int ref_count_ = 0;
 };
 
 }  // namespace video_coding
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_VIDEO_CODING_PACKET_BUFFER_H_