Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2535173008: Clean up FlexfecReceiveStream ctor signatures. (CL0) (Closed)

Created:
4 years ago by brandtr
Modified:
4 years ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clean up FlexfecReceiveStream ctor signatures. BUG=webrtc:5654 Committed: https://crrev.com/446fcb6cadb90fb47bc72053f29994ae56c80d1f Cr-Commit-Position: refs/heads/master@{#15476}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M webrtc/call/call.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/call.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download
M webrtc/call/flexfec_receive_stream.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/call/flexfec_receive_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (11 generated)
brandtr
In preparation of changes to the FlexfecReceiveStream::Config struct.
4 years ago (2016-12-01 09:21:04 UTC) #2
brandtr
ping :) This sequence of CLs (0-5) should give a simple, yet cohesive, picture of ...
4 years ago (2016-12-06 08:19:02 UTC) #4
stefan-webrtc
lgtm
4 years ago (2016-12-08 10:17:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2535173008/1
4 years ago (2016-12-08 10:20:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg/builds/9640) linux_baremetal on master.tryserver.webrtc (JOB_FAILED, ...
4 years ago (2016-12-08 10:21:36 UTC) #9
brandtr
Rebase.
4 years ago (2016-12-08 11:20:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2535173008/20001
4 years ago (2016-12-08 11:22:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2535173008/20001
4 years ago (2016-12-08 12:11:17 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 12:14:28 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-08 12:14:35 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/446fcb6cadb90fb47bc72053f29994ae56c80d1f
Cr-Commit-Position: refs/heads/master@{#15476}

Powered by Google App Engine
This is Rietveld 408576698