Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: webrtc/call/call.cc

Issue 2535173008: Clean up FlexfecReceiveStream ctor signatures. (CL0) (Closed)
Patch Set: Rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/call/call.h ('k') | webrtc/call/flexfec_receive_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/call.cc
diff --git a/webrtc/call/call.cc b/webrtc/call/call.cc
index 9a32df267b2fe0fca7a1fef53068a08bcf4ef587..6bd33a7ab2560c70a36cfa5b660a48c96a8f36e5 100644
--- a/webrtc/call/call.cc
+++ b/webrtc/call/call.cc
@@ -92,7 +92,7 @@ class Call : public webrtc::Call,
webrtc::VideoReceiveStream* receive_stream) override;
webrtc::FlexfecReceiveStream* CreateFlexfecReceiveStream(
- webrtc::FlexfecReceiveStream::Config configuration) override;
+ const webrtc::FlexfecReceiveStream::Config& config) override;
void DestroyFlexfecReceiveStream(
webrtc::FlexfecReceiveStream* receive_stream) override;
@@ -656,13 +656,11 @@ void Call::DestroyVideoReceiveStream(
}
webrtc::FlexfecReceiveStream* Call::CreateFlexfecReceiveStream(
- webrtc::FlexfecReceiveStream::Config configuration) {
+ const webrtc::FlexfecReceiveStream::Config& config) {
TRACE_EVENT0("webrtc", "Call::CreateFlexfecReceiveStream");
RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread());
- FlexfecReceiveStream* receive_stream =
- new FlexfecReceiveStream(std::move(configuration), this);
+ FlexfecReceiveStream* receive_stream = new FlexfecReceiveStream(config, this);
- const webrtc::FlexfecReceiveStream::Config& config = receive_stream->config();
{
WriteLockScoped write_lock(*receive_crit_);
for (auto ssrc : config.protected_media_ssrcs)
« no previous file with comments | « webrtc/call/call.h ('k') | webrtc/call/flexfec_receive_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698