Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAudioSource.h

Issue 2534843002: Added support for changing the volume of RTCAudioSource as discussed in BUG=webrtc:6533 (Closed)
Patch Set: implemented suggested changes by tkchin_webrtc Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« AUTHORS ('K') | « webrtc/sdk/objc/Framework/Classes/RTCAudioSource.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAudioSource.h
diff --git a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAudioSource.h b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAudioSource.h
index a86f42bbb75cd1f0d7d62806cac1335c1d62ee09..682f9cc364d1d3379e2fb93f8146c7b4507a47b7 100644
--- a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAudioSource.h
+++ b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAudioSource.h
@@ -20,6 +20,12 @@ RTC_EXPORT
- (instancetype)init NS_UNAVAILABLE;
+// Sets the volume to the RTCMediaSource. |volume| is in the range of [0, 10].
the sun 2016/12/01 18:24:19 Make that read: "Sets the volume for the RTCMedia
Frederik 2016/12/01 18:54:31 Done.
+// Temporary fix to be able to modify volume of remote audio tracks
+// TODO: implementing support for applyConstraints() to MediaStreamTrack will
the sun 2016/11/30 11:38:04 TODO should have an owner
+// replace this implementation
hta-webrtc 2016/12/01 13:59:15 I think the surface exposed by webrtc should have
the sun 2016/12/01 18:24:19 The [0..10] range stems from a DCHECK in RemoteAud
+@property(nonatomic, assign) double volume;
+
@end
NS_ASSUME_NONNULL_END
« AUTHORS ('K') | « webrtc/sdk/objc/Framework/Classes/RTCAudioSource.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698