Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCAudioSource.h

Issue 2534843002: Added support for changing the volume of RTCAudioSource as discussed in BUG=webrtc:6533 (Closed)
Patch Set: implemented suggested changes by tkchin_webrtc Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« AUTHORS ('K') | « webrtc/sdk/objc/Framework/Classes/RTCAudioSource.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #import <Foundation/Foundation.h> 11 #import <Foundation/Foundation.h>
12 12
13 #import <WebRTC/RTCMacros.h> 13 #import <WebRTC/RTCMacros.h>
14 #import <WebRTC/RTCMediaSource.h> 14 #import <WebRTC/RTCMediaSource.h>
15 15
16 NS_ASSUME_NONNULL_BEGIN 16 NS_ASSUME_NONNULL_BEGIN
17 17
18 RTC_EXPORT 18 RTC_EXPORT
19 @interface RTCAudioSource : RTCMediaSource 19 @interface RTCAudioSource : RTCMediaSource
20 20
21 - (instancetype)init NS_UNAVAILABLE; 21 - (instancetype)init NS_UNAVAILABLE;
22 22
23 // Sets the volume to the RTCMediaSource. |volume| is in the range of [0, 10].
the sun 2016/12/01 18:24:19 Make that read: "Sets the volume for the RTCMedia
Frederik 2016/12/01 18:54:31 Done.
24 // Temporary fix to be able to modify volume of remote audio tracks
25 // TODO: implementing support for applyConstraints() to MediaStreamTrack will
the sun 2016/11/30 11:38:04 TODO should have an owner
26 // replace this implementation
hta-webrtc 2016/12/01 13:59:15 I think the surface exposed by webrtc should have
the sun 2016/12/01 18:24:19 The [0..10] range stems from a DCHECK in RemoteAud
27 @property(nonatomic, assign) double volume;
28
23 @end 29 @end
24 30
25 NS_ASSUME_NONNULL_END 31 NS_ASSUME_NONNULL_END
OLDNEW
« AUTHORS ('K') | « webrtc/sdk/objc/Framework/Classes/RTCAudioSource.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698