Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: webrtc/base/stringutils.cc

Issue 2534683002: RTC_[D]CHECK_op: Remove superfluous casts (Closed)
Patch Set: test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/stringutils.cc
diff --git a/webrtc/base/stringutils.cc b/webrtc/base/stringutils.cc
index 48830e42338b4d4cf5660de53380a0e6fb3cc888..eca1362163e19a47a170a60e443ba420a34d130e 100644
--- a/webrtc/base/stringutils.cc
+++ b/webrtc/base/stringutils.cc
@@ -57,7 +57,7 @@ int ascii_string_compare(const wchar_t* s1, const char* s2, size_t n,
if (n-- == 0) return 0;
c1 = transformation(*s1);
// Double check that characters are not UTF-8
- RTC_DCHECK_LT(static_cast<unsigned char>(*s2), 128);
+ RTC_DCHECK_LT(*s2, 128);
// Note: *s2 gets implicitly promoted to wchar_t
c2 = transformation(*s2);
if (c1 != c2) return (c1 < c2) ? -1 : 1;
@@ -80,7 +80,7 @@ size_t asccpyn(wchar_t* buffer, size_t buflen,
#if RTC_DCHECK_IS_ON
// Double check that characters are not UTF-8
for (size_t pos = 0; pos < srclen; ++pos)
- RTC_DCHECK_LT(static_cast<unsigned char>(source[pos]), 128);
+ RTC_DCHECK_LT(source[pos], 128);
#endif
std::copy(source, source + srclen, buffer);
buffer[srclen] = 0;

Powered by Google App Engine
This is Rietveld 408576698