Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: webrtc/base/safe_compare_unittest.cc

Issue 2534683002: RTC_[D]CHECK_op: Remove superfluous casts (Closed)
Patch Set: test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/safe_compare_unittest.cc
diff --git a/webrtc/base/safe_compare_unittest.cc b/webrtc/base/safe_compare_unittest.cc
index 12ab4696efc44f80c58522dcb9d36a2e76394c64..f52c7eedcc3d9a50ef4220ad225bb979690f3c54 100644
--- a/webrtc/base/safe_compare_unittest.cc
+++ b/webrtc/base/safe_compare_unittest.cc
@@ -376,4 +376,19 @@ TEST(SafeCmpTest, Ge) {
EXPECT_TRUE(safe_cmp::Ge(p2, p2));
}
+TEST(SafeCmpTest, Enum) {
+ enum E1 { e1 = 13 };
+ enum { e2 = 13 };
+ enum E3 : unsigned { e3 = 13 };
+ enum : unsigned { e4 = 13 };
+ EXPECT_TRUE(safe_cmp::Eq(13, e1));
+ EXPECT_TRUE(safe_cmp::Eq(13u, e1));
+ EXPECT_TRUE(safe_cmp::Eq(13, e2));
+ EXPECT_TRUE(safe_cmp::Eq(13u, e2));
+ EXPECT_TRUE(safe_cmp::Eq(13, e3));
+ EXPECT_TRUE(safe_cmp::Eq(13u, e3));
+ EXPECT_TRUE(safe_cmp::Eq(13, e4));
+ EXPECT_TRUE(safe_cmp::Eq(13u, e4));
+}
+
} // namespace rtc

Powered by Google App Engine
This is Rietveld 408576698