Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: webrtc/base/fileutils.h

Issue 2533213005: Add File::Open / Create functions to take an rtc::Pathname (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/fileutils.h
diff --git a/webrtc/base/fileutils.h b/webrtc/base/fileutils.h
index 9489de8193df95e8cb28de55d5f36f832900e796..7ee9df850b63067d5f7d60446b8cb793bfacf56c 100644
--- a/webrtc/base/fileutils.h
+++ b/webrtc/base/fileutils.h
@@ -21,8 +21,7 @@
#include <unistd.h>
#endif
-#include "webrtc/base/basictypes.h"
-#include "webrtc/base/common.h"
+#include "webrtc/base/checks.h"
#include "webrtc/base/constructormagic.h"
#include "webrtc/base/platform_file.h"
@@ -175,14 +174,14 @@ class FilesystemInterface {
organization_name_ = organization;
}
void GetOrganizationName(std::string* organization) {
- ASSERT(NULL != organization);
+ RTC_DCHECK(NULL != organization);
stefan-webrtc 2016/12/06 10:12:36 organization != nullptr similar below
Hzj_jie 2016/12/06 22:33:07 Done.
*organization = organization_name_;
}
void SetApplicationName(const std::string& application) {
application_name_ = application;
}
void GetApplicationName(std::string* application) {
- ASSERT(NULL != application);
+ RTC_DCHECK(NULL != application);
*application = application_name_;
}
@@ -194,7 +193,7 @@ class FilesystemInterface {
class Filesystem {
public:
static FilesystemInterface *default_filesystem() {
- ASSERT(default_filesystem_ != NULL);
+ RTC_DCHECK(default_filesystem_ != NULL);
return default_filesystem_;
}
« no previous file with comments | « webrtc/base/file_unittest.cc ('k') | webrtc/base/flags.h » ('j') | webrtc/base/urlencode.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698