Add File::Open / Create functions to take an rtc::Pathname

webrtc/base/fileutils.h

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_BASE_FILEUTILS_H_
 #define WEBRTC_BASE_FILEUTILS_H_
 
 #include <string>
 
 #if !defined(WEBRTC_WIN)
 #include <dirent.h>
 #include <stdio.h>
 #include <sys/stat.h>
 #include <sys/types.h>
 #include <unistd.h>
 #endif
 
-#include "webrtc/base/basictypes.h"
-#include "webrtc/base/common.h"
+#include "webrtc/base/checks.h"
 #include "webrtc/base/constructormagic.h"
 #include "webrtc/base/platform_file.h"
 
 namespace rtc {
 
 class FileStream;
 class Pathname;
 
 //////////////////////////
 // Directory Iterator   //
@@ skipping 132 matching lines @@
   virtual bool GetAppTempFolder(Pathname* path) = 0;
 
   virtual bool GetDiskFreeSpace(const Pathname& path, int64_t* freebytes) = 0;
 
   // Note: These might go into some shared config section later, but they're
   // used by some methods in this interface, so we're leaving them here for now.
   void SetOrganizationName(const std::string& organization) {
     organization_name_ = organization;
   }
   void GetOrganizationName(std::string* organization) {
-    ASSERT(NULL != organization);
+    RTC_DCHECK(NULL != organization);

[stefan-webrtc, 2016/12/06 10:12:36]

organization != nullptr

similar below

[Hzj_jie, 2016/12/06 22:33:07]

Done.

     *organization = organization_name_;
   }
   void SetApplicationName(const std::string& application) {
     application_name_ = application;
   }
   void GetApplicationName(std::string* application) {
-    ASSERT(NULL != application);
+    RTC_DCHECK(NULL != application);
     *application = application_name_;
   }
 
  protected:
   std::string organization_name_;
   std::string application_name_;
 };
 
 class Filesystem {
  public:
   static FilesystemInterface *default_filesystem() {
-    ASSERT(default_filesystem_ != NULL);
+    RTC_DCHECK(default_filesystem_ != NULL);
     return default_filesystem_;
   }
 
   static void set_default_filesystem(FilesystemInterface *filesystem) {
     default_filesystem_ = filesystem;
   }
 
   static FilesystemInterface *swap_default_filesystem(
       FilesystemInterface *filesystem) {
     FilesystemInterface *cur = default_filesystem_;
@@ skipping 113 matching lines @@
     Filesystem::set_default_filesystem(old_fs_);
   }
  private:
   FilesystemInterface* old_fs_;
   RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(FilesystemScope);
 };
 
 }  // namespace rtc
 
 #endif  // WEBRTC_BASE_FILEUTILS_H_