Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2532523002: Move smoothing filter to common audio and exp_filter to base/analytics. (Closed)

Created:
4 years ago by minyue-webrtc
Modified:
4 years ago
Reviewers:
the sun, tommi, terelius
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), kwiberg-webrtc, stefan-webrtc, Andrew MacDonald, zhuangzesen_agora.io, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, mflodman, peah-webrtc, minyue-webrtc, zhengzhonghou_agora.io, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move smoothing filter to common audio and exp_filter to base/analytics. An earlier attempt of this work can be found here https://codereview.webrtc.org/2520003005/#ps100001, but was reverted. PS4 in that CL was not valid since separation of BUILD.gn can cause internal bot to fail. This is a new attempt, which is the same as https://codereview.webrtc.org/2520003005/#ps100001 but PS4 reverted. BUG=webrtc:6443 TBR=tommi@webrtc.org, solenberg@webrtc.org Committed: https://crrev.com/69b627d89de99cb59c271b4f7e1108800a91ddba Cr-Commit-Position: refs/heads/master@{#15233}

Patch Set 1 #

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -453 lines) Patch
M webrtc/BUILD.gn View 3 chunks +2 lines, -1 line 0 comments Download
M webrtc/base/BUILD.gn View 2 chunks +7 lines, -2 lines 0 comments Download
A + webrtc/base/analytics/exp_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/base/analytics/exp_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/base/analytics/exp_filter_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
D webrtc/base/exp_filter.h View 1 chunk +0 lines, -49 lines 0 comments Download
D webrtc/base/exp_filter.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D webrtc/base/exp_filter_unittest.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M webrtc/common_audio/BUILD.gn View 3 chunks +4 lines, -0 lines 0 comments Download
A + webrtc/common_audio/mocks/mock_smoothing_filter.h View 1 chunk +4 lines, -6 lines 0 comments Download
A + webrtc/common_audio/smoothing_filter.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + webrtc/common_audio/smoothing_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/common_audio/smoothing_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/fec_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_unittest.cc View 4 chunks +1 line, -4 lines 0 comments Download
D webrtc/modules/audio_coding/audio_network_adaptor/mock/mock_smoothing_filter.h View 1 chunk +0 lines, -29 lines 0 comments Download
D webrtc/modules/audio_coding/audio_network_adaptor/smoothing_filter.h View 1 chunk +0 lines, -54 lines 0 comments Download
D webrtc/modules/audio_coding/audio_network_adaptor/smoothing_filter.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D webrtc/modules/audio_coding/audio_network_adaptor/smoothing_filter_unittest.cc View 1 chunk +0 lines, -108 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/aimd_rate_control_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/media_opt_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/utility/frame_dropper.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/overuse_frame_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/overuse_frame_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
terelius
Could you update the CL description please.
4 years ago (2016-11-24 16:08:05 UTC) #3
terelius
I meant that about half of the changes are caused by moving the exp filter ...
4 years ago (2016-11-24 16:09:55 UTC) #4
minyue-webrtc
updated description
4 years ago (2016-11-24 16:15:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2532523002/1
4 years ago (2016-11-24 18:34:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg/builds/9206) android_compile_x86_dbg on master.tryserver.webrtc (JOB_FAILED, ...
4 years ago (2016-11-24 18:36:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2532523002/20001
4 years ago (2016-11-24 18:47:17 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-24 19:01:15 UTC) #17
commit-bot: I haz the power
4 years ago (2016-11-24 19:01:22 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69b627d89de99cb59c271b4f7e1108800a91ddba
Cr-Commit-Position: refs/heads/master@{#15233}

Powered by Google App Engine
This is Rietveld 408576698