webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_unittest.cc - Issue 2532523002: Move smoothing filter to common audio and exp_filter to base/analytics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_unittest.cc

Issue 2532523002: Move smoothing filter to common audio and exp_filter to base/analytics. (Closed)

Patch Set: typo Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/audio_network_adaptor/fec_controller.h ('k') | webrtc/modules/audio_coding/audio_network_adaptor/mock/mock_smoothing_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_unittest.cc

diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_unittest.cc b/webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_unittest.cc

index 9bbec26cbe83195d3129b974f0e46ee8ee428c79..823763f091985c3fda5128ef1d8dcd89a45fabdc 100644

--- a/webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_unittest.cc

+++ b/webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_unittest.cc

@@ -10,8 +10,8 @@

#include <utility>

+#include "webrtc/common_audio/mocks/mock_smoothing_filter.h"

#include "webrtc/modules/audio_coding/audio_network_adaptor/fec_controller.h"

-#include "webrtc/modules/audio_coding/audio_network_adaptor/mock/mock_smoothing_filter.h"

#include "webrtc/test/gtest.h"

namespace webrtc {

@@ -55,7 +55,6 @@ FecControllerStates CreateFecController(bool initial_fec_enabled) {

std::unique_ptr<MockSmoothingFilter> mock_smoothing_filter(

new NiceMock<MockSmoothingFilter>());

states.packet_loss_smoothed = mock_smoothing_filter.get();

- EXPECT_CALL(*states.packet_loss_smoothed, Die());

using Threshold = FecController::Config::Threshold;

states.controller.reset(new FecController(

FecController::Config(

@@ -262,7 +261,6 @@ TEST(FecControllerTest, CheckBehaviorOnSpecialCurves) {

std::unique_ptr<MockSmoothingFilter> mock_smoothing_filter(

new NiceMock<MockSmoothingFilter>());

states.packet_loss_smoothed = mock_smoothing_filter.get();

- EXPECT_CALL(*states.packet_loss_smoothed, Die());

using Threshold = FecController::Config::Threshold;

states.controller.reset(new FecController(

FecController::Config(

@@ -293,7 +291,6 @@ TEST(FecControllerDeathTest, InvalidConfig) {

std::unique_ptr<MockSmoothingFilter> mock_smoothing_filter(

new NiceMock<MockSmoothingFilter>());

states.packet_loss_smoothed = mock_smoothing_filter.get();

- EXPECT_CALL(*states.packet_loss_smoothed, Die());

using Threshold = FecController::Config::Threshold;

EXPECT_DEATH(

states.controller.reset(new FecController(