Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2531043002: Reland of move RTPPayloadStrategy and simplify RTPPayloadRegistry (Closed)

Created:
4 years ago by magjed_webrtc
Modified:
4 years ago
Reviewers:
the sun, danilchap, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman, hta-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of move RTPPayloadStrategy and simplify RTPPayloadRegistry (patchset #1 id:1 of https://codereview.webrtc.org/2528993002/ ) Reason for revert: Downstream code has been updated. Original issue's description: > Revert of Remove RTPPayloadStrategy and simplify RTPPayloadRegistry (patchset #7 id:240001 of https://codereview.webrtc.org/2524923002/ ) > > Reason for revert: > Breaks downstream projects. > > Original issue's description: > > Remove RTPPayloadStrategy and simplify RTPPayloadRegistry > > > > This CL removes RTPPayloadStrategy that is currently used to handle > > audio/video specific aspects of payload handling. Instead, the audio and > > video specific aspects will now have different functions, with linear > > code flow. > > > > This CL does not contain any functional changes, and is just a > > preparation for future CL:s. > > > > The main purpose with this CL is to add this function: > > bool PayloadIsCompatible(const RtpUtility::Payload& payload, > > const webrtc::VideoCodec& video_codec); > > that can easily be extended in a future CL to look at video codec > > specific information. > > > > BUG=webrtc:6743 > > > > Committed: https://crrev.com/b881254dc86d2cc80a52e08155433458be002166 > > Cr-Commit-Position: refs/heads/master@{#15232} > > TBR=danilchap@webrtc.org,solenberg@webrtc.org,mflodman@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6743 > > Committed: https://crrev.com/33c81d05613f45f65ee17224ed381c6cdd1c6c6f > Cr-Commit-Position: refs/heads/master@{#15234} TBR=danilchap@webrtc.org,solenberg@webrtc.org,mflodman@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6743 Committed: https://crrev.com/f3feeffe03af4b86fde8c30d3a07f82cef57d876 Cr-Commit-Position: refs/heads/master@{#15245}

Patch Set 1 #

Patch Set 2 : Remove deprecated RegisterReceivePayload function in RtpReceiver #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -585 lines) Patch
M webrtc/modules/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h View 1 3 chunks +16 lines, -59 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_receiver.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
D webrtc/modules/rtp_rtcp/source/mock/mock_rtp_payload_strategy.h View 1 chunk +0 lines, -43 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 1 8 chunks +148 lines, -260 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc View 1 4 chunks +116 lines, -159 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.h View 1 2 chunks +0 lines, -12 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc View 1 1 chunk +0 lines, -16 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_utility.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_video.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/video_coding/test/rtp_player.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/video/rtp_stream_receiver.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/channel.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
magjed_webrtc
Created Reland of move RTPPayloadStrategy and simplify RTPPayloadRegistry
4 years ago (2016-11-25 12:20:37 UTC) #1
magjed_webrtc
Internal bot green, relanding.
4 years ago (2016-11-25 14:40:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2531043002/260001
4 years ago (2016-11-25 14:40:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:260001)
4 years ago (2016-11-25 14:40:28 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-25 14:40:37 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f3feeffe03af4b86fde8c30d3a07f82cef57d876
Cr-Commit-Position: refs/heads/master@{#15245}

Powered by Google App Engine
This is Rietveld 408576698