Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 2525693003: Add H264 profile to webrtc::VideoCodecH264 and webrtc::VideoPayload (Closed)

Created:
4 years, 1 month ago by magjed_webrtc
Modified:
4 years ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add H264 profile to webrtc::VideoCodecH264 and webrtc::VideoPayload It's necessary to check H264 profile information as well as payload name in PayloadIsCompatible in RTPPayloadRegistry. BUG=webrtc:6743 Committed: https://crrev.com/bdbc4b7ef578ba1d61ceec351bc47c33da115329 Cr-Commit-Position: refs/heads/master@{#15248}

Patch Set 1 : Update RtpPayloadRegistry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M webrtc/common_types.h View 2 chunks +14 lines, -0 lines 0 comments Download
M webrtc/common_video/h264/profile_level_id.h View 2 chunks +1 line, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 1 chunk +8 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codec_database.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 34 (27 generated)
magjed_webrtc
mflodman - Please take a look. This is the final piece to get H264 profiles ...
4 years ago (2016-11-25 13:16:29 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2525693003/40001
4 years ago (2016-11-25 14:56:44 UTC) #23
mflodman
On 2016/11/25 14:56:44, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years ago (2016-11-25 15:01:58 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2525693003/40001
4 years ago (2016-11-25 15:12:48 UTC) #28
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years ago (2016-11-25 15:14:27 UTC) #31
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bdbc4b7ef578ba1d61ceec351bc47c33da115329 Cr-Commit-Position: refs/heads/master@{#15248}
4 years ago (2016-11-25 15:14:37 UTC) #33
magjed_webrtc
4 years ago (2016-11-25 17:33:55 UTC) #34
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:40001) has been created in
https://codereview.webrtc.org/2529143002/ by magjed@webrtc.org.

The reason for reverting is: The CL doesn't actually set profile information in
VideoPayload..

Powered by Google App Engine
This is Rietveld 408576698