Reland "Update rtt on audio only calls".

Reland "Update rtt on audio only calls".

https://codereview.webrtc.org/2402333002

BUG=webrtc:6508
Committed: https://crrev.com/9332b7d0ad5f2b8fd0f61dc0ca2e3b8181d2007b
Cr-Commit-Position: refs/heads/master@{#15340}

[michaelt, 2016-11-28 10:50:16]

Description was changed from

==========
Reland "Update rtt on audio only calls".

BUG=webrtc:6508
==========

to

==========
Reland "Update rtt on audio only calls".

BUG=webrtc:6508
==========

[michaelt, 2016-11-28 10:50:16]

michaelt@webrtc.org changed reviewers:
+ minyue@webrtc.org, solenberg@webrtc.org, stefan@webrtc.org

[minyue-webrtc, 2016-11-28 11:35:40]

lgtm

[michaelt, 2016-11-28 12:19:02]

Description was changed from

==========
Reland "Update rtt on audio only calls".

BUG=webrtc:6508
==========

to

==========
Reland "Update rtt on audio only calls".

https://codereview.webrtc.org/2402333002

BUG=webrtc:6508
==========

[the sun, 2016-11-28 13:17:55]

lgtm

https://codereview.webrtc.org/2530383002/diff/20001/webrtc/modules/rtp_rtcp/m...
File webrtc/modules/rtp_rtcp/mocks/mock_rtcp_rtt_stats.h (right):

https://codereview.webrtc.org/2530383002/diff/20001/webrtc/modules/rtp_rtcp/m...
webrtc/modules/rtp_rtcp/mocks/mock_rtcp_rtt_stats.h:22: 
nit: dd

[the sun, 2016-11-28 13:20:58]

lgtm

https://codereview.webrtc.org/2530383002/diff/20001/webrtc/voice_engine/chann...
File webrtc/voice_engine/channel.cc (right):

https://codereview.webrtc.org/2530383002/diff/20001/webrtc/voice_engine/chann...
webrtc/voice_engine/channel.cc:165: if (rtcp_rtt_stats_ == nullptr)
nit: !rtcp_rtt_stats_

[michaelt, 2016-11-28 13:47:35]

https://codereview.webrtc.org/2530383002/diff/20001/webrtc/modules/rtp_rtcp/m...
File webrtc/modules/rtp_rtcp/mocks/mock_rtcp_rtt_stats.h (right):

https://codereview.webrtc.org/2530383002/diff/20001/webrtc/modules/rtp_rtcp/m...
webrtc/modules/rtp_rtcp/mocks/mock_rtcp_rtt_stats.h:22: 
On 2016/11/28 13:17:55, the sun wrote:
> nit: dd

Done.

https://codereview.webrtc.org/2530383002/diff/20001/webrtc/voice_engine/chann...
File webrtc/voice_engine/channel.cc (right):

https://codereview.webrtc.org/2530383002/diff/20001/webrtc/voice_engine/chann...
webrtc/voice_engine/channel.cc:165: if (rtcp_rtt_stats_ == nullptr)
On 2016/11/28 13:20:58, the sun wrote:
> nit: !rtcp_rtt_stats_

Done.

[stefan-webrtc, 2016-11-29 16:16:52]

lgtm

[michaelt, 2016-11-30 08:05:14]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 08:05:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-30 08:06:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 08:06:33]

Dry run: Try jobs failed on following builders:
  ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/12937)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/15308)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/15167)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/20525)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/19241)
  linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
  linux_more_configs on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_more_configs/buil...)
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/19850)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/20598)
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10827)

[michaelt, 2016-11-30 10:29:11]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 10:29:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-30 10:42:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 10:42:39]

Dry run: Try jobs failed on following builders:
  linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)

[michaelt, 2016-11-30 14:41:10]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 14:41:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-30 14:42:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 14:42:43]

Dry run: Try jobs failed on following builders:
  linux_arm on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm/builds/3543)
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/16696)

[michaelt, 2016-11-30 15:11:27]

The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 15:11:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-30 15:31:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 15:31:24]

Dry run: This issue passed the CQ dry run.

[michaelt, 2016-11-30 15:48:57]

The CQ bit was checked by michaelt@webrtc.org

[michaelt, 2016-11-30 15:48:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
solenberg@webrtc.org, minyue@webrtc.org, stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2530383002/#ps100001 (title:
"Rebased.")

[commit-bot: I haz the power, 2016-11-30 15:49:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-30 15:51:14]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480520937420340,
"parent_rev": "d0bca119e16ea3edae310ebc2f64e6b3d1bcaae8", "commit_rev":
"2b4c279d9225649ecea6a69d583bcc5168397e07"}

[commit-bot: I haz the power, 2016-11-30 15:51:16]

Description was changed from

==========
Reland "Update rtt on audio only calls".

https://codereview.webrtc.org/2402333002

BUG=webrtc:6508
==========

to

==========
Reland "Update rtt on audio only calls".

https://codereview.webrtc.org/2402333002

BUG=webrtc:6508
==========

[commit-bot: I haz the power, 2016-11-30 15:51:18]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-30 15:51:28]

Description was changed from

==========
Reland "Update rtt on audio only calls".

https://codereview.webrtc.org/2402333002

BUG=webrtc:6508
==========

to

==========
Reland "Update rtt on audio only calls".

https://codereview.webrtc.org/2402333002

BUG=webrtc:6508

Committed: https://crrev.com/9332b7d0ad5f2b8fd0f61dc0ca2e3b8181d2007b
Cr-Commit-Position: refs/heads/master@{#15340}
==========

[commit-bot: I haz the power, 2016-11-30 15:51:29]

Patchset 6 (id:??) landed as
https://crrev.com/9332b7d0ad5f2b8fd0f61dc0ca2e3b8181d2007b
Cr-Commit-Position: refs/heads/master@{#15340}