Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2402333002: Add RtcpRttStats to AudioStream (Closed)

Created:
4 years, 2 months ago by michaelt
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add RtcpRttStats to AudioStream BUG=webrtc:6508 Committed: https://crrev.com/e0729c56d35acfaf9738fdb32c6508cd78eaf089 Cr-Commit-Position: refs/heads/master@{#14595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -19 lines) Patch
M webrtc/audio/audio_send_stream.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/audio/audio_send_stream.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 9 chunks +10 lines, -5 lines 0 comments Download
M webrtc/call/call.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/rtp_rtcp/mocks/mock_rtcp_rtt_stats.h View 1 chunk +9 lines, -11 lines 0 comments Download
M webrtc/test/mock_voe_channel_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/voice_engine/channel.h View 3 chunks +4 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 4 chunks +34 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
michaelt
4 years, 2 months ago (2016-10-10 13:40:18 UTC) #6
the sun
lgtm
4 years, 2 months ago (2016-10-10 13:57:31 UTC) #8
minyue-webrtc
lgtm
4 years, 2 months ago (2016-10-10 14:23:08 UTC) #11
stefan-webrtc
lgtm
4 years, 2 months ago (2016-10-10 15:14:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2402333002/1
4 years, 2 months ago (2016-10-11 07:20:51 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 07:29:32 UTC) #18
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e0729c56d35acfaf9738fdb32c6508cd78eaf089 Cr-Commit-Position: refs/heads/master@{#14595}
4 years, 2 months ago (2016-10-11 07:29:38 UTC) #20
sprang_webrtc
4 years, 2 months ago (2016-10-13 12:45:01 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2415943002/ by sprang@webrtc.org.

The reason for reverting is: Speculative revert.
Intermittent memory access errors suspected to be caused by this cl.

See for instance
https://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Light/bu...

UNADDRESSABLE ACCESS of freed memory: reading 0x0331d330-0x0331d334 4 byte(s)
# 0 webrtc::voe::RtcpRttStatsProxy::LastProcessedRtt
# 1 webrtc::ModuleRtpRtcpImpl::Process.

Powered by Google App Engine
This is Rietveld 408576698