Remove RTPPayloadStrategy and simplify RTPPayloadRegistry

webrtc/modules/rtp_rtcp/source/rtp_utility.h

Index: webrtc/modules/rtp_rtcp/source/rtp_utility.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_utility.h b/webrtc/modules/rtp_rtcp/source/rtp_utility.h
index 474bc6e04e00c9ac66121f4d5628af9ca022c8b0..1585298da7dfe0014f5cedc27d636cf5405c0a1e 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_utility.h
+++ b/webrtc/modules/rtp_rtcp/source/rtp_utility.h
@@ -39,6 +39,7 @@ struct Payload {
 typedef std::map<int8_t, Payload*> PayloadTypeMap;

[danilchap, 2016/11/23 19:06:18]

likely can remove this typedef now

[magjed_webrtc, 2016/11/24 12:20:39]

I tried, but it was used in PossiblyRemoveExistingPayloadType in
webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.h. I see now that
PossiblyRemoveExistingPayloadType is a dead function and not used. I removed it.

 
 bool StringCompare(const char* str1, const char* str2, const uint32_t length);

[danilchap, 2016/11/23 19:06:18]

these two function are not specific to rtp.
May be rather than adding missing function here, add it to /base/stringutils.h"

[magjed_webrtc, 2016/11/24 12:20:39]

I asked tommi@ about this. He thinks it's best to just remove these helper
functions and write '_stricmp(str1, str2) == 0' directly, i.e. no helper
function for doing the '== 0' part. I will do that in a separate CL to not
pollute this CL.

[danilchap, 2016/11/24 13:24:36]

using _stricmp directly instead of introducing a new function in this CL feel
less polluting.
(removing already existent StringCompare function agree better leave for another
CL)

[magjed_webrtc, 2016/11/24 14:29:29]

True, done.

+bool StringCompare(const char* str1, const char* str2);
 
 // Round up to the nearest size that is a multiple of 4.
 size_t Word32Align(size_t size);