Remove RTPPayloadStrategy and simplify RTPPayloadRegistry

webrtc/modules/rtp_rtcp/source/rtp_utility.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 18 matching lines @@
 ReceiveStatistics* NullObjectReceiveStatistics();
 
 namespace RtpUtility {
 
 struct Payload {
   char name[RTP_PAYLOAD_NAME_SIZE];
   bool audio;
   PayloadUnion typeSpecific;
 };
 
 typedef std::map<int8_t, Payload*> PayloadTypeMap;

[danilchap, 2016/11/23 19:06:18]

likely can remove this typedef now

[magjed_webrtc, 2016/11/24 12:20:39]

I tried, but it was used in PossiblyRemoveExistingPayloadType in
webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.h. I see now that
PossiblyRemoveExistingPayloadType is a dead function and not used. I removed it.

 
 bool StringCompare(const char* str1, const char* str2, const uint32_t length);

[danilchap, 2016/11/23 19:06:18]

these two function are not specific to rtp.
May be rather than adding missing function here, add it to /base/stringutils.h"

[magjed_webrtc, 2016/11/24 12:20:39]

I asked tommi@ about this. He thinks it's best to just remove these helper
functions and write '_stricmp(str1, str2) == 0' directly, i.e. no helper
function for doing the '== 0' part. I will do that in a separate CL to not
pollute this CL.

[danilchap, 2016/11/24 13:24:36]

using _stricmp directly instead of introducing a new function in this CL feel
less polluting.
(removing already existent StringCompare function agree better leave for another
CL)

[magjed_webrtc, 2016/11/24 14:29:29]

True, done.

+bool StringCompare(const char* str1, const char* str2);
 
 // Round up to the nearest size that is a multiple of 4.
 size_t Word32Align(size_t size);
 
 class RtpHeaderParser {
  public:
   RtpHeaderParser(const uint8_t* rtpData, size_t rtpDataLength);
   ~RtpHeaderParser();
 
   bool RTCP() const;
@@ skipping 10 matching lines @@
   uint8_t ParsePaddingBytes(const uint8_t* ptrRTPDataExtensionEnd,
                             const uint8_t* ptr) const;
 
   const uint8_t* const _ptrRTPDataBegin;
   const uint8_t* const _ptrRTPDataEnd;
 };
 }  // namespace RtpUtility
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_UTILITY_H_