Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2522023003: RTCPeerConnectionStats: Removed fixed TODO comments. (Closed)

Created:
4 years ago by hbos
Modified:
4 years ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTCPeerConnectionStats: Removed fixed TODO comments. I forget to remove these when fixing them. BUG=chromium:636818 NOTRY=True NOPRESUBMIT=True Committed: https://crrev.com/42eee12614c8b931f416c9830dc247eba85e73b1 Cr-Commit-Position: refs/heads/master@{#15215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M webrtc/api/stats/rtcstats_objects.h View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2522023003/1
4 years ago (2016-11-23 15:39:19 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-11-23 15:39:21 UTC) #4
hta-webrtc
lgtm
4 years ago (2016-11-23 15:42:48 UTC) #6
hbos
Please take a look, hta.
4 years ago (2016-11-23 15:42:53 UTC) #7
hbos
On 2016/11/23 15:42:53, hbos wrote: > Please take a look, hta. :)
4 years ago (2016-11-23 15:43:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2522023003/1
4 years ago (2016-11-23 15:43:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 15:43:26 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-23 15:43:35 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42eee12614c8b931f416c9830dc247eba85e73b1
Cr-Commit-Position: refs/heads/master@{#15215}

Powered by Google App Engine
This is Rietveld 408576698