Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Side by Side Diff: webrtc/api/stats/rtcstats_objects.h

Issue 2522023003: RTCPeerConnectionStats: Removed fixed TODO comments. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 RTCStatsMember<uint32_t> partial_frames_lost; 260 RTCStatsMember<uint32_t> partial_frames_lost;
261 // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/659137 261 // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/659137
262 RTCStatsMember<uint32_t> full_frames_lost; 262 RTCStatsMember<uint32_t> full_frames_lost;
263 // Audio-only members 263 // Audio-only members
264 RTCStatsMember<double> audio_level; 264 RTCStatsMember<double> audio_level;
265 RTCStatsMember<double> echo_return_loss; 265 RTCStatsMember<double> echo_return_loss;
266 RTCStatsMember<double> echo_return_loss_enhancement; 266 RTCStatsMember<double> echo_return_loss_enhancement;
267 }; 267 };
268 268
269 // https://w3c.github.io/webrtc-stats/#pcstats-dict* 269 // https://w3c.github.io/webrtc-stats/#pcstats-dict*
270 // TODO(hbos): Tracking bug crbug.com/636818
271 class RTCPeerConnectionStats final : public RTCStats { 270 class RTCPeerConnectionStats final : public RTCStats {
272 public: 271 public:
273 WEBRTC_RTCSTATS_DECL(); 272 WEBRTC_RTCSTATS_DECL();
274 273
275 RTCPeerConnectionStats(const std::string& id, int64_t timestamp_us); 274 RTCPeerConnectionStats(const std::string& id, int64_t timestamp_us);
276 RTCPeerConnectionStats(std::string&& id, int64_t timestamp_us); 275 RTCPeerConnectionStats(std::string&& id, int64_t timestamp_us);
277 RTCPeerConnectionStats(const RTCPeerConnectionStats& other); 276 RTCPeerConnectionStats(const RTCPeerConnectionStats& other);
278 ~RTCPeerConnectionStats() override; 277 ~RTCPeerConnectionStats() override;
279 278
280 // TODO(hbos): Collected by |RTCStatsCollector| but different than the spec.
281 // crbug.com/636818
282 RTCStatsMember<uint32_t> data_channels_opened; 279 RTCStatsMember<uint32_t> data_channels_opened;
283 // TODO(hbos): Collected by |RTCStatsCollector| but different than the spec.
284 // crbug.com/636818
285 RTCStatsMember<uint32_t> data_channels_closed; 280 RTCStatsMember<uint32_t> data_channels_closed;
286 }; 281 };
287 282
288 // https://w3c.github.io/webrtc-stats/#streamstats-dict* 283 // https://w3c.github.io/webrtc-stats/#streamstats-dict*
289 // TODO(hbos): Tracking bug crbug.com/657854 284 // TODO(hbos): Tracking bug crbug.com/657854
290 class RTCRTPStreamStats : public RTCStats { 285 class RTCRTPStreamStats : public RTCStats {
291 public: 286 public:
292 WEBRTC_RTCSTATS_DECL(); 287 WEBRTC_RTCSTATS_DECL();
293 288
294 RTCRTPStreamStats(const RTCRTPStreamStats& other); 289 RTCRTPStreamStats(const RTCRTPStreamStats& other);
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
397 RTCStatsMember<std::string> rtcp_transport_stats_id; 392 RTCStatsMember<std::string> rtcp_transport_stats_id;
398 RTCStatsMember<bool> active_connection; 393 RTCStatsMember<bool> active_connection;
399 RTCStatsMember<std::string> selected_candidate_pair_id; 394 RTCStatsMember<std::string> selected_candidate_pair_id;
400 RTCStatsMember<std::string> local_certificate_id; 395 RTCStatsMember<std::string> local_certificate_id;
401 RTCStatsMember<std::string> remote_certificate_id; 396 RTCStatsMember<std::string> remote_certificate_id;
402 }; 397 };
403 398
404 } // namespace webrtc 399 } // namespace webrtc
405 400
406 #endif // WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_ 401 #endif // WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698