Chromium Code Reviews

Issue 2518263003: Move VideoDecoderSoftwareFallbackWrapper from webrtc/video_decoder.h to webrtc/media/engine/ (Closed)

Created:
4 years, 1 month ago by magjed_webrtc
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move VideoDecoderSoftwareFallbackWrapper from webrtc/video_decoder.h to webrtc/media/engine/ The class VideoDecoderSoftwareFallbackWrapper is an implementation detail of webrtc/media/engine/webrtcvideoengine2.cc and should not be directly under webrtc/video_decoder.h. The main purpose is to improve the dependency graph in WebRTC so that VideoDecoderSoftwareFallbackWrapper can depend on cricket::VideoCodec. The test for VideoDecoderSoftwareFallbackWrapper is also moved from webrtc/video/video_decoder_unittest.cc to webrtc/media/engine/videodecodersoftwarefallbackwrapper_unittest.cc. BUG=webrtc:6743 TBR=stefan@webrtc.org Committed: https://crrev.com/f6acc2a7107323b6078edd5b15ee757d9da10dae Cr-Commit-Position: refs/heads/master@{#15180}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+19 lines, -473 lines)
M webrtc/media/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments
A + webrtc/media/engine/videodecodersoftwarefallbackwrapper.h View 3 chunks +5 lines, -93 lines 0 comments
A + webrtc/media/engine/videodecodersoftwarefallbackwrapper.cc View 4 chunks +9 lines, -63 lines 0 comments
A + webrtc/media/engine/videodecodersoftwarefallbackwrapper_unittest.cc View 1 chunk +1 line, -0 lines 0 comments
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +1 line, -0 lines 0 comments
M webrtc/video/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments
M webrtc/video/video_decoder.cc View 1 chunk +0 lines, -106 lines 0 comments
D webrtc/video/video_decoder_unittest.cc View 1 chunk +0 lines, -172 lines 0 comments
M webrtc/video_decoder.h View 1 chunk +0 lines, -38 lines 0 comments

Dependent Patchsets:

Messages

Total messages: 19 (15 generated)
magjed_webrtc
Stefan - I know that you are busy so I'm TBR:ing this CL. It's pure ...
4 years, 1 month ago (2016-11-22 09:41:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2518263003/40001
4 years, 1 month ago (2016-11-22 09:41:48 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 1 month ago (2016-11-22 09:43:06 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 09:43:11 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6acc2a7107323b6078edd5b15ee757d9da10dae
Cr-Commit-Position: refs/heads/master@{#15180}

Powered by Google App Engine