Move VideoDecoder::Create() logic to separate internal video decoder factory

Move VideoDecoder::Create() logic to separate internal video decoder factory

The goal with this CL is to move implementation details out from the
webrtc root (webrtc/video_decoder.h) to simplify the dependency graph.
Another goal is to streamline the creation of VideoDecoders in
webrtcvideoengine2.cc; it will now have two factories of the same
WebRtcVideoDecoderFactory type, one internal and one external.

Specifically, this CL:
 * Removes webrtc::VideoDecoder::DecoderType and use webrtc::VideoCodecType
   instead.
 * Removes 'static VideoDecoder* Create(DecoderType codec_type)' and
   moves the create function to the internal decoder factory instead.
 * Removes video_decoder.cc. webrtc::VideoDecoder is now just an
   interface without any static functions.

BUG=webrtc:6743
Committed: https://crrev.com/dd40702357dbd09e4468eee295193f9fd4a7da7b
Cr-Commit-Position: refs/heads/master@{#15350}

[magjed_webrtc, 2016-11-22 09:07:38]

Patchset #1 (id:1) has been deleted

[magjed_webrtc, 2016-11-22 09:07:48]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 09:07:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2016-11-22 09:35:20]

Description was changed from

==========
Move VideoDecoder::Create() logic to separate internal video decoder factory

BUG=webrtc:6337
==========

to

==========
Move VideoDecoder::Create() logic to separate internal video decoder factory

BUG=webrtc:6743
==========

[magjed_webrtc, 2016-11-22 09:35:30]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[magjed_webrtc, 2016-11-22 09:35:36]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-11-22 09:35:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-22 09:45:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 09:45:07]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[magjed_webrtc, 2016-11-22 10:08:53]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 10:08:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-22 10:24:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 10:24:30]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2016-11-22 10:43:22]

Description was changed from

==========
Move VideoDecoder::Create() logic to separate internal video decoder factory

BUG=webrtc:6743
==========

to

==========
Move VideoDecoder::Create() logic to separate internal video decoder factory

The goal with this CL is to move implementation details out from the
webrtc root (webrtc/video_decoder.h) to simplify the dependency graph.
Another goal is to streamline the creation of VideoDecoders in
webrtcvideoengine2.cc; it will now have two factories of the same
WebRtcVideoDecoderFactory type, one internal and one external.

Specifically, this CL:
 * Removes webrtc::VideoDecoder::DecoderType and use webrtc::VideoCodecType
   instead.
 * Removes 'static VideoDecoder* Create(DecoderType codec_type)' and
   moves the create function to the internal decoder factory instead.
 * Removes video_decoder.cc. webrtc::VideoDecoder is now just an
   interface without any static functions.

BUG=webrtc:6743
==========

[magjed_webrtc, 2016-11-22 10:43:23]

magjed@webrtc.org changed reviewers:
+ stefan@webrtc.org

[magjed_webrtc, 2016-11-22 10:45:18]

Stefan - please take a look.

[magjed_webrtc, 2016-11-28 11:32:25]

Stefan - ping.

[stefan-webrtc, 2016-11-29 16:07:37]

I would prefer if you included an OWNER of webrtc/media since I'm not. However,
I don't think it looks particularly complicated, so in this case I could bypass
if you prefer that. :)

A test might be a good idea, even though the class is simple...

https://codereview.webrtc.org/2521203002/diff/60001/webrtc/media/engine/inter...
File webrtc/media/engine/internaldecoderfactory.h (right):

https://codereview.webrtc.org/2521203002/diff/60001/webrtc/media/engine/inter...
webrtc/media/engine/internaldecoderfactory.h:20: class InternalDecoderFactory :
public WebRtcVideoDecoderFactory {
Should we add some simple tests for this class?

[magjed_webrtc, 2016-11-30 16:17:36]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 16:17:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2016-11-30 16:18:48]

I'm an owner of webrtc/media so it should be fine.

https://codereview.webrtc.org/2521203002/diff/60001/webrtc/media/engine/inter...
File webrtc/media/engine/internaldecoderfactory.h (right):

https://codereview.webrtc.org/2521203002/diff/60001/webrtc/media/engine/inter...
webrtc/media/engine/internaldecoderfactory.h:20: class InternalDecoderFactory :
public WebRtcVideoDecoderFactory {
On 2016/11/29 16:07:37, stefan-webrtc (holmer) wrote:
> Should we add some simple tests for this class?

Done, not much logic to test though, but probably good to exercise the normal
case.

[stefan-webrtc, 2016-11-30 16:22:22]

On 2016/11/30 16:18:48, magjed_webrtc wrote:
> I'm an owner of webrtc/media so it should be fine.
> 
>
https://codereview.webrtc.org/2521203002/diff/60001/webrtc/media/engine/inter...
> File webrtc/media/engine/internaldecoderfactory.h (right):
> 
>
https://codereview.webrtc.org/2521203002/diff/60001/webrtc/media/engine/inter...
> webrtc/media/engine/internaldecoderfactory.h:20: class InternalDecoderFactory
:
> public WebRtcVideoDecoderFactory {
> On 2016/11/29 16:07:37, stefan-webrtc (holmer) wrote:
> > Should we add some simple tests for this class?
> 
> Done, not much logic to test though, but probably good to exercise the normal
> case.

Ah, missed that. Lgtm then!

[commit-bot: I haz the power, 2016-11-30 16:42:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 16:42:54]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2016-12-01 08:25:49]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-12-01 08:25:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-01 08:27:27]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480580749242740,
"parent_rev": "b34416394f9cce8cb4146c603deafe9290d0ce7c", "commit_rev":
"ddea35978640f9d32687f8b1b1a8c8997c186744"}

[commit-bot: I haz the power, 2016-12-01 08:27:30]

Description was changed from

==========
Move VideoDecoder::Create() logic to separate internal video decoder factory

The goal with this CL is to move implementation details out from the
webrtc root (webrtc/video_decoder.h) to simplify the dependency graph.
Another goal is to streamline the creation of VideoDecoders in
webrtcvideoengine2.cc; it will now have two factories of the same
WebRtcVideoDecoderFactory type, one internal and one external.

Specifically, this CL:
 * Removes webrtc::VideoDecoder::DecoderType and use webrtc::VideoCodecType
   instead.
 * Removes 'static VideoDecoder* Create(DecoderType codec_type)' and
   moves the create function to the internal decoder factory instead.
 * Removes video_decoder.cc. webrtc::VideoDecoder is now just an
   interface without any static functions.

BUG=webrtc:6743
==========

to

==========
Move VideoDecoder::Create() logic to separate internal video decoder factory

The goal with this CL is to move implementation details out from the
webrtc root (webrtc/video_decoder.h) to simplify the dependency graph.
Another goal is to streamline the creation of VideoDecoders in
webrtcvideoengine2.cc; it will now have two factories of the same
WebRtcVideoDecoderFactory type, one internal and one external.

Specifically, this CL:
 * Removes webrtc::VideoDecoder::DecoderType and use webrtc::VideoCodecType
   instead.
 * Removes 'static VideoDecoder* Create(DecoderType codec_type)' and
   moves the create function to the internal decoder factory instead.
 * Removes video_decoder.cc. webrtc::VideoDecoder is now just an
   interface without any static functions.

BUG=webrtc:6743
==========

[commit-bot: I haz the power, 2016-12-01 08:27:31]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-12-01 08:27:42]

Description was changed from

==========
Move VideoDecoder::Create() logic to separate internal video decoder factory

The goal with this CL is to move implementation details out from the
webrtc root (webrtc/video_decoder.h) to simplify the dependency graph.
Another goal is to streamline the creation of VideoDecoders in
webrtcvideoengine2.cc; it will now have two factories of the same
WebRtcVideoDecoderFactory type, one internal and one external.

Specifically, this CL:
 * Removes webrtc::VideoDecoder::DecoderType and use webrtc::VideoCodecType
   instead.
 * Removes 'static VideoDecoder* Create(DecoderType codec_type)' and
   moves the create function to the internal decoder factory instead.
 * Removes video_decoder.cc. webrtc::VideoDecoder is now just an
   interface without any static functions.

BUG=webrtc:6743
==========

to

==========
Move VideoDecoder::Create() logic to separate internal video decoder factory

The goal with this CL is to move implementation details out from the
webrtc root (webrtc/video_decoder.h) to simplify the dependency graph.
Another goal is to streamline the creation of VideoDecoders in
webrtcvideoengine2.cc; it will now have two factories of the same
WebRtcVideoDecoderFactory type, one internal and one external.

Specifically, this CL:
 * Removes webrtc::VideoDecoder::DecoderType and use webrtc::VideoCodecType
   instead.
 * Removes 'static VideoDecoder* Create(DecoderType codec_type)' and
   moves the create function to the internal decoder factory instead.
 * Removes video_decoder.cc. webrtc::VideoDecoder is now just an
   interface without any static functions.

BUG=webrtc:6743

Committed: https://crrev.com/dd40702357dbd09e4468eee295193f9fd4a7da7b
Cr-Commit-Position: refs/heads/master@{#15350}
==========

[commit-bot: I haz the power, 2016-12-01 08:27:43]

Patchset 3 (id:??) landed as
https://crrev.com/dd40702357dbd09e4468eee295193f9fd4a7da7b
Cr-Commit-Position: refs/heads/master@{#15350}