iOS: Add FlexFEC-03 field trial.

iOS: Add FlexFEC-03 field trial.

NOTRY=true
BUG=webrtc:5654
R=tkchin@webrtc.org
CC=magjed@webrtc.org

Committed: https://crrev.com/96385e0432c903f01f647c654f8d34309f1b0a7c
Cr-Commit-Position: refs/heads/master@{#15176}

[brandtr, 2016-11-21 09:31:36]

Please have a look :)

[tkchin_webrtc, 2016-11-21 18:16:59]

https://codereview.webrtc.org/2517123002/diff/1/webrtc/sdk/objc/Framework/Cla...
File webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm (right):

https://codereview.webrtc.org/2517123002/diff/1/webrtc/sdk/objc/Framework/Cla...
webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm:32: if (options &
RTCFieldTrialOptionsFlexfec03) {
Shouldn't this be in a new block? Why is the audio field trial being removed?

https://codereview.webrtc.org/2517123002/diff/1/webrtc/sdk/objc/Framework/Hea...
File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFieldTrials.h (right):

https://codereview.webrtc.org/2517123002/diff/1/webrtc/sdk/objc/Framework/Hea...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFieldTrials.h:19:
RTCFieldTrialOptionsFlexfec03 = 1 << 2,
nit: FlexFec03

[brandtr, 2016-11-21 19:39:36]

Patchset #2 (id:20001) has been deleted

[brandtr, 2016-11-21 19:43:06]

https://codereview.webrtc.org/2517123002/diff/1/webrtc/sdk/objc/Framework/Cla...
File webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm (right):

https://codereview.webrtc.org/2517123002/diff/1/webrtc/sdk/objc/Framework/Cla...
webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm:32: if (options &
RTCFieldTrialOptionsFlexfec03) {
On 2016/11/21 18:16:59, tkchin_webrtc wrote:
> Shouldn't this be in a new block? Why is the audio field trial being removed?

Yes, of course it should be a new block! And the audio field trial should still
be there. Sorry for this, very sloppy of me. I must have not double checked the
uploaded CL, because I thought it was so small...

https://codereview.webrtc.org/2517123002/diff/1/webrtc/sdk/objc/Framework/Hea...
File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFieldTrials.h (right):

https://codereview.webrtc.org/2517123002/diff/1/webrtc/sdk/objc/Framework/Hea...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFieldTrials.h:19:
RTCFieldTrialOptionsFlexfec03 = 1 << 2,
On 2016/11/21 18:16:59, tkchin_webrtc wrote:
> nit: FlexFec03

Done.

[tkchin_webrtc, 2016-11-21 19:46:02]

lgtm

https://codereview.webrtc.org/2517123002/diff/1/webrtc/sdk/objc/Framework/Cla...
File webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm (right):

https://codereview.webrtc.org/2517123002/diff/1/webrtc/sdk/objc/Framework/Cla...
webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm:32: if (options &
RTCFieldTrialOptionsFlexfec03) {
On 2016/11/21 19:43:06, brandtr wrote:
> On 2016/11/21 18:16:59, tkchin_webrtc wrote:
> > Shouldn't this be in a new block? Why is the audio field trial being
removed?
> 
> Yes, of course it should be a new block! And the audio field trial should
still
> be there. Sorry for this, very sloppy of me. I must have not double checked
the
> uploaded CL, because I thought it was so small...

No worries, I was just confused :)

[brandtr, 2016-11-21 19:47:58]

On 2016/11/21 19:46:02, tkchin_webrtc wrote:
> lgtm
> 
>
https://codereview.webrtc.org/2517123002/diff/1/webrtc/sdk/objc/Framework/Cla...
> File webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm (right):
> 
>
https://codereview.webrtc.org/2517123002/diff/1/webrtc/sdk/objc/Framework/Cla...
> webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm:32: if (options &
> RTCFieldTrialOptionsFlexfec03) {
> On 2016/11/21 19:43:06, brandtr wrote:
> > On 2016/11/21 18:16:59, tkchin_webrtc wrote:
> > > Shouldn't this be in a new block? Why is the audio field trial being
> removed?
> > 
> > Yes, of course it should be a new block! And the audio field trial should
> still
> > be there. Sorry for this, very sloppy of me. I must have not double checked
> the
> > uploaded CL, because I thought it was so small...
> 
> No worries, I was just confused :)

:)

Thanks for quick response!

[brandtr, 2016-11-22 07:42:00]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2016-11-22 07:42:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-22 07:43:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479800520816330,
"parent_rev": "1927bc8bccff20c85438e07975af3ad250f1a748", "commit_rev":
"611e55cb65b1c2b362c74640951ccc07c6049f5c"}

[commit-bot: I haz the power, 2016-11-22 07:43:21]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-22 07:43:32]

Description was changed from

==========
iOS: Add FlexFEC-03 field trial.

NOTRY=true
BUG=webrtc:5654
R=tkchin@webrtc.org
CC=magjed@webrtc.org
==========

to

==========
iOS: Add FlexFEC-03 field trial.

NOTRY=true
BUG=webrtc:5654
R=tkchin@webrtc.org
CC=magjed@webrtc.org

Committed: https://crrev.com/96385e0432c903f01f647c654f8d34309f1b0a7c
Cr-Commit-Position: refs/heads/master@{#15176}
==========

[commit-bot: I haz the power, 2016-11-22 07:43:33]

Patchset 2 (id:??) landed as
https://crrev.com/96385e0432c903f01f647c654f8d34309f1b0a7c
Cr-Commit-Position: refs/heads/master@{#15176}