Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Side by Side Diff: webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm

Issue 2517123002: iOS: Add FlexFEC-03 field trial. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #import "WebRTC/RTCFieldTrials.h" 11 #import "WebRTC/RTCFieldTrials.h"
12 12
13 #include <memory> 13 #include <memory>
14 14
15 #import "WebRTC/RTCLogging.h" 15 #import "WebRTC/RTCLogging.h"
16 16
17 #include "webrtc/system_wrappers/include/field_trial_default.h" 17 #include "webrtc/system_wrappers/include/field_trial_default.h"
18 18
19 static NSString * const kRTCEnableImprovedBitrateEstimateString = 19 static NSString * const kRTCEnableImprovedBitrateEstimateString =
20 @"WebRTC-ImprovedBitrateEstimate/Enabled/"; 20 @"WebRTC-ImprovedBitrateEstimate/Enabled/";
21 static NSString * const kRTCEnableAudioSendSideBweString = 21 static NSString * const kRTCEnableAudioSendSideBweString =
22 @"WebRTC-Audio-SendSideBwe/Enabled/"; 22 @"WebRTC-Audio-SendSideBwe/Enabled/";
23 static NSString * const kRTCEnableFlexfec03String =
24 @"WebRTC-FlexFEC-03/Enabled/";
23 static std::unique_ptr<char[]> gFieldTrialInitString; 25 static std::unique_ptr<char[]> gFieldTrialInitString;
24 26
25 void RTCInitFieldTrials(RTCFieldTrialOptions options) { 27 void RTCInitFieldTrials(RTCFieldTrialOptions options) {
26 NSMutableString *fieldTrialInitString = [NSMutableString string]; 28 NSMutableString *fieldTrialInitString = [NSMutableString string];
27 if (options & RTCFieldTrialOptionsImprovedBitrateEstimate) { 29 if (options & RTCFieldTrialOptionsImprovedBitrateEstimate) {
28 [fieldTrialInitString appendString:kRTCEnableImprovedBitrateEstimateString]; 30 [fieldTrialInitString appendString:kRTCEnableImprovedBitrateEstimateString];
29 } 31 }
30 if (options & RTCFieldTrialOptionsAudioSendSideBwe) { 32 if (options & RTCFieldTrialOptionsFlexfec03) {
tkchin_webrtc 2016/11/21 18:16:59 Shouldn't this be in a new block? Why is the audio
brandtr 2016/11/21 19:43:06 Yes, of course it should be a new block! And the a
tkchin_webrtc 2016/11/21 19:46:02 No worries, I was just confused :)
31 [fieldTrialInitString appendString:kRTCEnableAudioSendSideBweString]; 33 [fieldTrialInitString appendString:kRTCEnableFlexfec03String];
32 } 34 }
33 size_t len = fieldTrialInitString.length + 1; 35 size_t len = fieldTrialInitString.length + 1;
34 gFieldTrialInitString.reset(new char[len]); 36 gFieldTrialInitString.reset(new char[len]);
35 if (![fieldTrialInitString getCString:gFieldTrialInitString.get() 37 if (![fieldTrialInitString getCString:gFieldTrialInitString.get()
36 maxLength:len 38 maxLength:len
37 encoding:NSUTF8StringEncoding]) { 39 encoding:NSUTF8StringEncoding]) {
38 RTCLogError(@"Failed to convert field trial string."); 40 RTCLogError(@"Failed to convert field trial string.");
39 return; 41 return;
40 } 42 }
41 webrtc::field_trial::InitFieldTrialsFromString(gFieldTrialInitString.get()); 43 webrtc::field_trial::InitFieldTrialsFromString(gFieldTrialInitString.get());
42 } 44 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698