Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/test/BUILD.gn

Issue 2515443003: Move FirewallSocketServer to test code. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/base/BUILD.gn ('K') | « webrtc/p2p/client/basicportallocator_unittest.cc ('k') | webrtc/test/firewallsocketserver.h » ('j') | webrtc/test/firewallsocketserver.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/test/BUILD.gn
diff --git a/webrtc/test/BUILD.gn b/webrtc/test/BUILD.gn
index 126857b50c6612dedf72a52bbe9f7ad5a3eff30e..2ab46ec58bcd95c7a87191ac2f535a9eae7272be 100644
--- a/webrtc/test/BUILD.gn
+++ b/webrtc/test/BUILD.gn
@@ -297,6 +297,8 @@ rtc_source_set("test_common") {
"fake_network_pipe.cc",
"fake_network_pipe.h",
"fake_videorenderer.h",
+ "firewallsocketserver.cc",
+ "firewallsocketserver.h",
"frame_generator_capturer.cc",
"frame_generator_capturer.h",
"layer_filtering_transport.cc",
@@ -331,7 +333,7 @@ rtc_source_set("test_common") {
":test_support",
"..:webrtc_common",
"../audio",
- "../base:rtc_base_approved",
+ "../base:rtc_base",
nisse-webrtc 2016/11/18 11:17:45 This violates dependency rules. But imo, test code
"../call",
"../modules/audio_device:mock_audio_device",
"../modules/audio_mixer:audio_mixer_impl",
« webrtc/base/BUILD.gn ('K') | « webrtc/p2p/client/basicportallocator_unittest.cc ('k') | webrtc/test/firewallsocketserver.h » ('j') | webrtc/test/firewallsocketserver.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698