Move FirewallSocketServer to test code.

webrtc/test/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../build/webrtc.gni")
 import("//build/config/ui.gni")
@@ skipping 279 matching lines @@
     "encoder_settings.h",
     "fake_audio_device.cc",
     "fake_audio_device.h",
     "fake_decoder.cc",
     "fake_decoder.h",
     "fake_encoder.cc",
     "fake_encoder.h",
     "fake_network_pipe.cc",
     "fake_network_pipe.h",
     "fake_videorenderer.h",
+    "firewallsocketserver.cc",
+    "firewallsocketserver.h",
     "frame_generator_capturer.cc",
     "frame_generator_capturer.h",
     "layer_filtering_transport.cc",
     "layer_filtering_transport.h",
     "mock_transport.h",
     "mock_voe_channel_proxy.h",
     "mock_voice_engine.h",
     "null_transport.cc",
     "null_transport.h",
     "rtp_rtcp_observer.h",
@@ skipping 14 matching lines @@
   if (!build_with_chromium && is_clang) {
     # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   deps = [
     ":rtp_test_utils",
     ":test_support",
     "..:webrtc_common",
     "../audio",
-    "../base:rtc_base_approved",
+    "../base:rtc_base",

[nisse-webrtc, 2016/11/18 11:17:45]

This violates dependency rules. But imo, test code ought to be allowed to depend
on more or less anything. How do we solve this?

It's needed because the base class of FirewallSocketServer is defined in
base/socketserver.cc, which is in rtc_base but (for good reason, I guess) not in
rtc_base_approved.

     "../call",
     "../modules/audio_device:mock_audio_device",
     "../modules/audio_mixer:audio_mixer_impl",
     "../modules/audio_processing",
     "../modules/media_file",
     "../modules/video_capture:video_capture_module",
     "../video",
     "//testing/gmock",
     "//testing/gtest",
   ]
@@ skipping 64 matching lines @@
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   deps = [
     ":test_support",
     ":video_test_common",
     "../modules/media_file",
     "//testing/gtest",
   ]
 }