Initial rate allocation should not use fps = 0

webrtc/modules/video_coding/video_coding_impl.h

Index: webrtc/modules/video_coding/video_coding_impl.h
diff --git a/webrtc/modules/video_coding/video_coding_impl.h b/webrtc/modules/video_coding/video_coding_impl.h
index adeb980072e7ec020f161c0429460cb55ed8a1d7..791a60bda83bd231820a9c6de9068a86ff9f9d5c 100644
--- a/webrtc/modules/video_coding/video_coding_impl.h
+++ b/webrtc/modules/video_coding/video_coding_impl.h
@@ -40,6 +40,8 @@ namespace vcm {
 
 class VCMProcessTimer {
  public:
+  static const int64_t kDefaultProcessIntervalMs = 1000;

[danilchap, 2016/11/21 10:43:25]

Do you plan to use this constant outside SendVideo too?

[sprang_webrtc, 2016/11/21 11:35:32]

I use it the unit test now.

+
   VCMProcessTimer(int64_t periodMs, Clock* clock)
       : _clock(clock),
         _periodMs(periodMs),
@@ -112,6 +114,7 @@ class VideoSender : public Module {
   rtc::CriticalSection encoder_crit_;
   VCMGenericEncoder* _encoder;
   media_optimization::MediaOptimization _mediaOpt;
+  bool has_received_frame_;

[danilchap, 2016/11/21 10:43:25]

can it be used from multiple threads? may be protect with a crit_ then.
if not, may be add GUARDED_BY(sequenced_checker_)
(if it is more complicated, but you sure there will be no race, can guard by
race_checker)

[sprang_webrtc, 2016/11/21 11:35:32]

I moved it and protected it by params_crit_

   VCMEncodedFrameCallback _encodedFrameCallback GUARDED_BY(encoder_crit_);
   VCMSendStatisticsCallback* const send_stats_callback_;
   VCMCodecDataBase _codecDataBase GUARDED_BY(encoder_crit_);