Initial rate allocation should not use fps = 0

webrtc/modules/video_coding/video_coding_impl.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 22 matching lines @@
 #include "webrtc/system_wrappers/include/clock.h"
 
 namespace webrtc {
 
 class VideoBitrateAllocator;
 
 namespace vcm {
 
 class VCMProcessTimer {
  public:
+  static const int64_t kDefaultProcessIntervalMs = 1000;

[danilchap, 2016/11/21 10:43:25]

Do you plan to use this constant outside SendVideo too?

[sprang_webrtc, 2016/11/21 11:35:32]

I use it the unit test now.

+
   VCMProcessTimer(int64_t periodMs, Clock* clock)
       : _clock(clock),
         _periodMs(periodMs),
         _latestMs(_clock->TimeInMilliseconds()) {}
   int64_t Period() const;
   int64_t TimeUntilProcess() const;
   void Processed();
 
  private:
   Clock* _clock;
@@ skipping 52 matching lines @@
       VideoBitrateAllocator* bitrate_allocator,
       uint32_t target_bitrate_bps);
   void SetEncoderParameters(EncoderParameters params, bool has_internal_source)
       EXCLUSIVE_LOCKS_REQUIRED(encoder_crit_);
 
   Clock* const clock_;
 
   rtc::CriticalSection encoder_crit_;
   VCMGenericEncoder* _encoder;
   media_optimization::MediaOptimization _mediaOpt;
+  bool has_received_frame_;

[danilchap, 2016/11/21 10:43:25]

can it be used from multiple threads? may be protect with a crit_ then.
if not, may be add GUARDED_BY(sequenced_checker_)
(if it is more complicated, but you sure there will be no race, can guard by
race_checker)

[sprang_webrtc, 2016/11/21 11:35:32]

I moved it and protected it by params_crit_

   VCMEncodedFrameCallback _encodedFrameCallback GUARDED_BY(encoder_crit_);
   VCMSendStatisticsCallback* const send_stats_callback_;
   VCMCodecDataBase _codecDataBase GUARDED_BY(encoder_crit_);
   bool frame_dropper_enabled_ GUARDED_BY(encoder_crit_);
   VCMProcessTimer _sendStatsTimer;
 
   // Must be accessed on the construction thread of VideoSender.
   VideoCodec current_codec_;
   rtc::SequencedTaskChecker sequenced_checker_;
 
@@ skipping 90 matching lines @@
   VCMProcessTimer _receiveStatsTimer;
   VCMProcessTimer _retransmissionTimer;
   VCMProcessTimer _keyRequestTimer;
   QpParser qp_parser_;
   ThreadUnsafeOneTimeEvent first_frame_received_;
 };
 
 }  // namespace vcm
 }  // namespace webrtc
 #endif  // WEBRTC_MODULES_VIDEO_CODING_VIDEO_CODING_IMPL_H_