Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h

Issue 2513063003: Add the OnAddTrack callback for Objective-C wrapper.
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h
diff --git a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h
index 4438eb28ab5ecf4fb53c4a7e645ff0c08bd4c5da..ed4aaf0f555fe928e654fcebb8585c2a4bd9c7e5 100644
--- a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h
+++ b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h
@@ -106,6 +106,12 @@ RTC_EXPORT
- (void)peerConnection:(RTCPeerConnection *)peerConnection
didOpenDataChannel:(RTCDataChannel *)dataChannel;
+@optional
+/** Called when a new track is signaled from remote peer. */
+- (void)peerConnection:(RTCPeerConnection*)peerConnection
+ didAddTrack:(RTCRtpReceiver*)rtpReceiver
tkchin_webrtc 2016/11/22 20:41:34 align : space after * (RTCPeerConnection *) NSArr
Zhi Huang 2016/11/22 23:38:42 Done. Should I align the ":" in previous function
+ attachedStreams:(NSArray<RTCMediaStream*>*)mediaStreams;
tkchin_webrtc 2016/11/22 20:41:34 Seems different than spec? https://www.w3.org/TR/w
Zhi Huang 2016/11/22 23:38:42 According to the spec, the Receiver is required. W
+
@end
RTC_EXPORT

Powered by Google App Engine
This is Rietveld 408576698