Chromium Code Reviews

Side by Side Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h

Issue 2513063003: Add the OnAddTrack callback for Objective-C wrapper.
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 88 matching lines...)
99 didGenerateIceCandidate:(RTCIceCandidate *)candidate; 99 didGenerateIceCandidate:(RTCIceCandidate *)candidate;
100 100
101 /** Called when a group of local Ice candidates have been removed. */ 101 /** Called when a group of local Ice candidates have been removed. */
102 - (void)peerConnection:(RTCPeerConnection *)peerConnection 102 - (void)peerConnection:(RTCPeerConnection *)peerConnection
103 didRemoveIceCandidates:(NSArray<RTCIceCandidate *> *)candidates; 103 didRemoveIceCandidates:(NSArray<RTCIceCandidate *> *)candidates;
104 104
105 /** New data channel has been opened. */ 105 /** New data channel has been opened. */
106 - (void)peerConnection:(RTCPeerConnection *)peerConnection 106 - (void)peerConnection:(RTCPeerConnection *)peerConnection
107 didOpenDataChannel:(RTCDataChannel *)dataChannel; 107 didOpenDataChannel:(RTCDataChannel *)dataChannel;
108 108
109 @optional
110 /** Called when a new track is signaled from remote peer. */
111 - (void)peerConnection:(RTCPeerConnection*)peerConnection
112 didAddTrack:(RTCRtpReceiver*)rtpReceiver
tkchin_webrtc 2016/11/22 20:41:34 align : space after * (RTCPeerConnection *) NSArr
Zhi Huang 2016/11/22 23:38:42 Done. Should I align the ":" in previous function
113 attachedStreams:(NSArray<RTCMediaStream*>*)mediaStreams;
tkchin_webrtc 2016/11/22 20:41:34 Seems different than spec? https://www.w3.org/TR/w
Zhi Huang 2016/11/22 23:38:42 According to the spec, the Receiver is required. W
114
109 @end 115 @end
110 116
111 RTC_EXPORT 117 RTC_EXPORT
112 @interface RTCPeerConnection : NSObject 118 @interface RTCPeerConnection : NSObject
113 119
114 /** The object that will be notifed about events such as state changes and 120 /** The object that will be notifed about events such as state changes and
115 * streams being added or removed. 121 * streams being added or removed.
116 */ 122 */
117 @property(nonatomic, weak, nullable) id<RTCPeerConnectionDelegate> delegate; 123 @property(nonatomic, weak, nullable) id<RTCPeerConnectionDelegate> delegate;
118 @property(nonatomic, readonly) NSArray<RTCMediaStream *> *localStreams; 124 @property(nonatomic, readonly) NSArray<RTCMediaStream *> *localStreams;
(...skipping 96 matching lines...)
215 */ 221 */
216 - (void)statsForTrack: 222 - (void)statsForTrack:
217 (nullable RTCMediaStreamTrack *)mediaStreamTrack 223 (nullable RTCMediaStreamTrack *)mediaStreamTrack
218 statsOutputLevel:(RTCStatsOutputLevel)statsOutputLevel 224 statsOutputLevel:(RTCStatsOutputLevel)statsOutputLevel
219 completionHandler: 225 completionHandler:
220 (nullable void (^)(NSArray<RTCLegacyStatsReport *> *stats))completionHandler ; 226 (nullable void (^)(NSArray<RTCLegacyStatsReport *> *stats))completionHandler ;
221 227
222 @end 228 @end
223 229
224 NS_ASSUME_NONNULL_END 230 NS_ASSUME_NONNULL_END
OLDNEW

Powered by Google App Engine