Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: webrtc/sdk/objc/Framework/Classes/RTCPeerConnection+Private.h

Issue 2513063003: Add the OnAddTrack callback for Objective-C wrapper.
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Classes/RTCPeerConnection+Private.h
diff --git a/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection+Private.h b/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection+Private.h
index 60ab868a7c515a9dec6a54f7a4eafe008826cb29..e9fa4975eb56ec64d24cae15f3f94454426d9b00 100644
--- a/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection+Private.h
+++ b/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection+Private.h
@@ -49,8 +49,17 @@ class PeerConnectionDelegateAdapter : public PeerConnectionObserver {
void OnIceCandidatesRemoved(
const std::vector<cricket::Candidate>& candidates) override;
+ void OnAddTrack(
tkchin_webrtc 2016/11/22 20:41:34 what is the distinction between track and receiver
Zhi Huang 2016/11/22 23:38:42 There is one track attached to one RtpReceiver. A
+ rtc::scoped_refptr<RtpReceiverInterface> receiver,
+ std::vector<rtc::scoped_refptr<MediaStreamInterface>> streams) override;
+
private:
- __weak RTCPeerConnection *peer_connection_;
+ RTCMediaStream* GetOrCreateObjcStream(
+ rtc::scoped_refptr<MediaStreamInterface> stream);
+
+ __weak RTCPeerConnection* peer_connection_;
+ NSMutableDictionary* nativeToObjcMediaStream_ =
+ [NSMutableDictionary dictionary];
tkchin_webrtc 2016/11/22 20:41:34 Shouldn't this be initialized in ctor?
Zhi Huang 2016/11/22 23:38:42 Done.
};
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698