RTCCodecStats added

webrtc/api/stats/rtcstats_objects.h

Index: webrtc/api/stats/rtcstats_objects.h
diff --git a/webrtc/api/stats/rtcstats_objects.h b/webrtc/api/stats/rtcstats_objects.h
index 3263379e227d173d5b9dd4c11023ab0f15f3d4e9..8a5a5c896d4c885e1efe530e76b1586bad18d30e 100644
--- a/webrtc/api/stats/rtcstats_objects.h
+++ b/webrtc/api/stats/rtcstats_objects.h
@@ -59,6 +59,31 @@ class RTCCertificateStats final : public RTCStats {
   RTCStatsMember<std::string> issuer_certificate_id;
 };
 
+// https://w3c.github.io/webrtc-stats/#codec-dict*
+// TODO(hbos): Finish implementation. Tracking bug crbug.com/659117
+// Codec stats objects currently aren't identified correctly, this could result
+// in multiple stats objects for the same codec or an ID being reused if a
+// stream changes codec.

[hta-webrtc, 2016/11/23 07:37:35]

I don't think this is true at the moment.... direction + type + PT will give you
unique and stable IDs as long as you don't have multiple m= lines using the same
payload type (which, again, can only happen if you don't bundle connections).

It would be more correct to say "TODO(hbos): The present codec ID assignment is
not sufficient to support Unified Plan or unbundled connections in all cases."

[hbos, 2016/11/23 09:40:59]

Done.

+class RTCCodecStats final : public RTCStats {
+ public:
+  WEBRTC_RTCSTATS_DECL();
+
+  RTCCodecStats(const std::string& id, int64_t timestamp_us);
+  RTCCodecStats(std::string&& id, int64_t timestamp_us);
+  RTCCodecStats(const RTCCodecStats& other);
+  ~RTCCodecStats() override;
+
+  RTCStatsMember<uint32_t> payload_type;
+  RTCStatsMember<std::string> codec;
+  RTCStatsMember<uint32_t> clock_rate;
+  // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/659117
+  RTCStatsMember<uint32_t> channels;
+  // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/659117
+  RTCStatsMember<std::string> parameters;
+  // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/659117
+  RTCStatsMember<std::string> implementation;
+};
+
 // https://w3c.github.io/webrtc-stats/#dcstats-dict*
 class RTCDataChannelStats final : public RTCStats {
  public:
@@ -281,7 +306,6 @@ class RTCRTPStreamStats : public RTCStats {
   // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657854, 659137
   RTCStatsMember<std::string> media_track_id;
   RTCStatsMember<std::string> transport_id;
-  // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657854, 659117
   RTCStatsMember<std::string> codec_id;
   // FIR and PLI counts are only defined for |media_type == "video"|.
   RTCStatsMember<uint32_t> fir_count;