RTCCodecStats added

webrtc/api/stats/rtcstats_objects.h

 /*
  *  Copyright 2016 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 41 matching lines @@
   RTCCertificateStats(std::string&& id, int64_t timestamp_us);
   RTCCertificateStats(const RTCCertificateStats& other);
   ~RTCCertificateStats() override;
 
   RTCStatsMember<std::string> fingerprint;
   RTCStatsMember<std::string> fingerprint_algorithm;
   RTCStatsMember<std::string> base64_certificate;
   RTCStatsMember<std::string> issuer_certificate_id;
 };
 
+// https://w3c.github.io/webrtc-stats/#codec-dict*
+// TODO(hbos): Finish implementation. Tracking bug crbug.com/659117
+// Codec stats objects currently aren't identified correctly, this could result
+// in multiple stats objects for the same codec or an ID being reused if a
+// stream changes codec.

[hta-webrtc, 2016/11/23 07:37:35]

I don't think this is true at the moment.... direction + type + PT will give you
unique and stable IDs as long as you don't have multiple m= lines using the same
payload type (which, again, can only happen if you don't bundle connections).

It would be more correct to say "TODO(hbos): The present codec ID assignment is
not sufficient to support Unified Plan or unbundled connections in all cases."

[hbos, 2016/11/23 09:40:59]

Done.

+class RTCCodecStats final : public RTCStats {
+ public:
+  WEBRTC_RTCSTATS_DECL();
+
+  RTCCodecStats(const std::string& id, int64_t timestamp_us);
+  RTCCodecStats(std::string&& id, int64_t timestamp_us);
+  RTCCodecStats(const RTCCodecStats& other);
+  ~RTCCodecStats() override;
+
+  RTCStatsMember<uint32_t> payload_type;
+  RTCStatsMember<std::string> codec;
+  RTCStatsMember<uint32_t> clock_rate;
+  // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/659117
+  RTCStatsMember<uint32_t> channels;
+  // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/659117
+  RTCStatsMember<std::string> parameters;
+  // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/659117
+  RTCStatsMember<std::string> implementation;
+};
+
 // https://w3c.github.io/webrtc-stats/#dcstats-dict*
 class RTCDataChannelStats final : public RTCStats {
  public:
   WEBRTC_RTCSTATS_DECL();
 
   RTCDataChannelStats(const std::string& id, int64_t timestamp_us);
   RTCDataChannelStats(std::string&& id, int64_t timestamp_us);
   RTCDataChannelStats(const RTCDataChannelStats& other);
   ~RTCDataChannelStats() override;
 
@@ skipping 202 matching lines @@
   // TODO(hbos): When the remote case is supported |RTCStatsCollector| needs to
   // set this. crbug.com/657855, 657856
   RTCStatsMember<std::string> associate_stats_id;
   // TODO(hbos): Remote case not supported by |RTCStatsCollector|.
   // crbug.com/657855, 657856
   RTCStatsMember<bool> is_remote;  // = false
   RTCStatsMember<std::string> media_type;
   // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657854, 659137
   RTCStatsMember<std::string> media_track_id;
   RTCStatsMember<std::string> transport_id;
-  // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657854, 659117
   RTCStatsMember<std::string> codec_id;
   // FIR and PLI counts are only defined for |media_type == "video"|.
   RTCStatsMember<uint32_t> fir_count;
   RTCStatsMember<uint32_t> pli_count;
   // TODO(hbos): NACK count should be collected by |RTCStatsCollector| for both
   // audio and video but is only defined in the "video" case. crbug.com/657856
   RTCStatsMember<uint32_t> nack_count;
   // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/657854
   // SLI count is only defined for |media_type == "video"|.
   RTCStatsMember<uint32_t> sli_count;
@@ skipping 79 matching lines @@
   RTCStatsMember<std::string> rtcp_transport_stats_id;
   RTCStatsMember<bool> active_connection;
   RTCStatsMember<std::string> selected_candidate_pair_id;
   RTCStatsMember<std::string> local_certificate_id;
   RTCStatsMember<std::string> remote_certificate_id;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_