Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sync_chromium.py

Issue 2509703002: Remove all references to GYP (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « setup_links.py ('k') | third_party/gflags/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync_chromium.py
diff --git a/sync_chromium.py b/sync_chromium.py
index 91b1931a96c4ce27865b21e29f33c485ff5a4b89..8a32996fe255240cc9587856b45458f2aa0346a6 100755
--- a/sync_chromium.py
+++ b/sync_chromium.py
@@ -116,8 +116,6 @@ def main():
# Avoid downloading NaCl toolchain as part of the Chromium hooks.
env.setdefault('GYP_DEFINES', '')
ehmaldonado_webrtc 2016/11/16 16:07:41 What about this?
kjellander_webrtc 2016/11/16 16:39:27 Yeah let's remove it.
- env['GYP_DEFINES'] += ' disable_nacl=1'
- env['GYP_CHROMIUM_NO_ACTION'] = '1'
gclient_cmd = 'gclient.bat' if sys.platform.startswith('win') else 'gclient'
args = [
gclient_cmd, 'sync', '--force', '--revision', 'src@'+opts.target_revision
« no previous file with comments | « setup_links.py ('k') | third_party/gflags/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698