Unify VideoCodecType to/from string functionality

Unify VideoCodecType to/from string functionality

BUG=None

Committed: https://crrev.com/10165ab8e72f1aa947d25222f4c1895ad7b1792f
Cr-Commit-Position: refs/heads/master@{#15200}

[magjed_webrtc, 2016-11-17 13:06:18]

Description was changed from

==========
Unify VideoCodecType to/from string functionality

BUG=None
==========

to

==========
Unify VideoCodecType to/from string functionality

BUG=None
==========

[magjed_webrtc, 2016-11-17 13:06:18]

magjed@webrtc.org changed reviewers:
+ sprang@webrtc.org, stefan@webrtc.org

[magjed_webrtc, 2016-11-17 13:08:29]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 13:08:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-17 13:12:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 13:12:10]

Dry run: Try jobs failed on following builders:
  ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/12602)

[magjed_webrtc, 2016-11-17 13:42:28]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 13:42:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-17 14:00:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 14:00:03]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2016-11-17 14:39:22]

Patchset #1 (id:1) has been deleted

[magjed_webrtc, 2016-11-17 14:39:47]

Please take a look.

[sprang_webrtc, 2016-11-18 07:10:48]

lgtm % minor question

https://codereview.webrtc.org/2509273002/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvideoencoderfactory.cc (right):

https://codereview.webrtc.org/2509273002/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvideoencoderfactory.cc:35:
webrtc::CodecTypeToPayloadName(type).value_or("Unknown"));
The name will now be "Unknown" instead of "Unknown codec". 
I hope nothing is dependent on that exact string?

[magjed_webrtc, 2016-11-18 09:54:40]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 09:54:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-18 10:00:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 10:00:19]

Dry run: Try jobs failed on following builders:
  android_clang_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/build...)

[magjed_webrtc, 2016-11-18 10:32:55]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 10:33:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-18 11:05:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 11:05:34]

Dry run: This issue passed the CQ dry run.

[magjed1, 2016-11-18 11:47:37]

Patchset #2 (id:40001) has been deleted

[magjed1, 2016-11-18 11:48:17]

magjed@google.com changed reviewers:
+ magjed@google.com

[magjed1, 2016-11-18 11:48:18]

https://codereview.webrtc.org/2509273002/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvideoencoderfactory.cc (right):

https://codereview.webrtc.org/2509273002/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvideoencoderfactory.cc:35:
webrtc::CodecTypeToPayloadName(type).value_or("Unknown"));
On 2016/11/18 07:10:48, språng wrote:
> The name will now be "Unknown" instead of "Unknown codec". 
> I hope nothing is dependent on that exact string?

I changed it back to "Unknown codec" just in case.

[magjed_webrtc, 2016-11-18 14:45:40]

magjed@webrtc.org changed reviewers:
- magjed@google.com

[stefan-webrtc, 2016-11-22 16:08:45]

lgtm

[magjed_webrtc, 2016-11-22 16:16:36]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2016-11-22 16:16:36]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2509273002/#ps60001 (title:
"Rebase and update unknown string in WebRtcVideoEncoderFactory")

[commit-bot: I haz the power, 2016-11-22 16:16:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-22 16:40:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 16:40:43]

Try jobs failed on following builders:
  android_more_configs on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_more_configs/bu...)

[magjed1, 2016-11-22 17:57:49]

The CQ bit was checked by magjed@google.com

[commit-bot: I haz the power, 2016-11-22 17:58:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-22 18:16:58]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479837469863520,
"parent_rev": "01c6da242d39aaa896471d2fc9fda7692397f0a4", "commit_rev":
"a0be7479dc4b2770ea251244e45a3107e4720510"}

[commit-bot: I haz the power, 2016-11-22 18:17:01]

Description was changed from

==========
Unify VideoCodecType to/from string functionality

BUG=None
==========

to

==========
Unify VideoCodecType to/from string functionality

BUG=None
==========

[commit-bot: I haz the power, 2016-11-22 18:17:03]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-11-22 18:17:06]

Description was changed from

==========
Unify VideoCodecType to/from string functionality

BUG=None
==========

to

==========
Unify VideoCodecType to/from string functionality

BUG=None

Committed: https://crrev.com/10165ab8e72f1aa947d25222f4c1895ad7b1792f
Cr-Commit-Position: refs/heads/master@{#15200}
==========

[commit-bot: I haz the power, 2016-11-22 18:17:07]

Patchset 2 (id:??) landed as
https://crrev.com/10165ab8e72f1aa947d25222f4c1895ad7b1792f
Cr-Commit-Position: refs/heads/master@{#15200}