Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: webrtc/media/engine/webrtcvideoencoderfactory.cc

Issue 2509273002: Unify VideoCodecType to/from string functionality (Closed)
Patch Set: Rebase and update unknown string in WebRtcVideoEncoderFactory Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/engine/internalencoderfactory.cc ('k') | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvideoencoderfactory.cc
diff --git a/webrtc/media/engine/webrtcvideoencoderfactory.cc b/webrtc/media/engine/webrtcvideoencoderfactory.cc
index ccc32d894bf2e19e336b972b04abca212e95424f..c7e5ac47fdb015b4f8ef452afff3f5598878dbfd 100644
--- a/webrtc/media/engine/webrtcvideoencoderfactory.cc
+++ b/webrtc/media/engine/webrtcvideoencoderfactory.cc
@@ -10,26 +10,14 @@
#include "webrtc/media/engine/webrtcvideoencoderfactory.h"
-#include "webrtc/media/base/mediaconstants.h"
-
-static const char* NameFromCodecType(webrtc::VideoCodecType type) {
- switch (type) {
- case webrtc::kVideoCodecVP8:
- return cricket::kVp8CodecName;
- case webrtc::kVideoCodecVP9:
- return cricket::kVp9CodecName;
- case webrtc::kVideoCodecH264:
- return cricket::kH264CodecName;
- default:
- return "Unknown codec";
- }
-}
+#include "webrtc/common_types.h"
namespace cricket {
webrtc::VideoEncoder* WebRtcVideoEncoderFactory::CreateVideoEncoder(
const cricket::VideoCodec& codec) {
- return CreateVideoEncoder(CodecTypeFromName(codec.name));
+ return CreateVideoEncoder(webrtc::PayloadNameToCodecType(codec.name)
+ .value_or(webrtc::kVideoCodecUnknown));
}
const std::vector<cricket::VideoCodec>&
@@ -43,7 +31,8 @@ WebRtcVideoEncoderFactory::supported_codecs() const {
webrtc::VideoEncoder* WebRtcVideoEncoderFactory::CreateVideoEncoder(
webrtc::VideoCodecType type) {
- const cricket::VideoCodec codec(NameFromCodecType(type));
+ const cricket::VideoCodec codec(
+ webrtc::CodecTypeToPayloadName(type).value_or("Unknown codec"));
return CreateVideoEncoder(codec);
}
@@ -52,7 +41,9 @@ WebRtcVideoEncoderFactory::codecs() const {
const std::vector<cricket::VideoCodec>& codecs = supported_codecs();
for (const cricket::VideoCodec& codec : codecs) {
encoder_codecs_.push_back(
- VideoCodec(CodecTypeFromName(codec.name), codec.name));
+ VideoCodec(webrtc::PayloadNameToCodecType(codec.name)
+ .value_or(webrtc::kVideoCodecUnknown),
+ codec.name));
}
return encoder_codecs_;
}
« no previous file with comments | « webrtc/media/engine/internalencoderfactory.cc ('k') | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698