Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2507213002:
Switching from CLD2 to CLD3 (Closed)
|
Created:
4 years, 1 month ago by Anton Bakalov Modified:
3 years, 2 months ago CC:
chromium-reviews, djweiss1, riesa Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSwitching from CLD2 to CLD3
This CL switches from the old language detection model to the new one.
BUG=
Committed: https://crrev.com/c88b9d3e89b67efaffae68cd6d81a0f23db0848b
Cr-Commit-Position: refs/heads/master@{#432769}
Patch Set 1 #
Messages
Total messages: 25 (12 generated)
The CQ bit was checked by abakalov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Switching from CLD2 to CLD3 BUG= ========== to ========== Switching from CLD2 to CLD3 This CL switches from the old language detection model to the new one. BUG= ==========
abakalov@chromium.org changed reviewers: + groby@chromium.org, rouslan@chromium.org
groby@google.com changed reviewers: + groby@google.com
lgtm
lgtm
groby@chromium.org changed reviewers: - groby@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by abakalov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Switching from CLD2 to CLD3 This CL switches from the old language detection model to the new one. BUG= ========== to ========== Switching from CLD2 to CLD3 This CL switches from the old language detection model to the new one. BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Switching from CLD2 to CLD3 This CL switches from the old language detection model to the new one. BUG= ========== to ========== Switching from CLD2 to CLD3 This CL switches from the old language detection model to the new one. BUG= Committed: https://crrev.com/c88b9d3e89b67efaffae68cd6d81a0f23db0848b Cr-Commit-Position: refs/heads/master@{#432769} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c88b9d3e89b67efaffae68cd6d81a0f23db0848b Cr-Commit-Position: refs/heads/master@{#432769}
Message was sent while issue was closed.
thakis@chromium.org changed reviewers: + thakis@chromium.org
Message was sent while issue was closed.
Can we remove cld3 from deps now? (Also, there should've been a bug for the cld2->3 transition and this change here should've had that on the BUG= line)
Message was sent while issue was closed.
Sorry, *can we remove cld _2_ from deps now
Message was sent while issue was closed.
On 2017/03/07 21:56:05, Nico wrote: > Sorry, *can we remove cld _2_ from deps now Given that there is a small but significant fraction of people who haven't updated their browser yet, I'd personally vote for keeping cld_2 around for one more release cycle. Is there any pressing need to remove it? Yes, there is a launch bug associated with the switch. Sorry I missed to include it.
Message was sent while issue was closed.
On Tue, Mar 7, 2017 at 5:07 PM, <abakalov@chromium.org> wrote: > On 2017/03/07 21:56:05, Nico wrote: > > Sorry, *can we remove cld _2_ from deps now > > Given that there is a small but significant fraction of people who haven't > updated their browser yet, I'd personally vote for keeping cld_2 around > for one > more release cycle. Is there any pressing need to remove it? > Is cld 2 used by anything? I didn't see any references to it in the build graph. If keeping it around has any effect I don't have a problem with it, but I'm currently not seeing which effect it has :-) > > Yes, there is a launch bug associated with the switch. Sorry I missed to > include > it. > > https://codereview.chromium.org/2507213002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Can we remove CLD2 now?
Message was sent while issue was closed.
On 2017/09/29 18:48:23, Nico wrote: > Can we remove CLD2 now? SGTM
Message was sent while issue was closed.
Are you preparing a CL? On Fri, Sep 29, 2017 at 3:01 PM, <riesa@google.com> wrote: > On 2017/09/29 18:48:23, Nico wrote: > > Can we remove CLD2 now? > > SGTM > > https://codereview.chromium.org/2507213002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
