Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2507063008: iOS: Cleanup buildbot JSON files + bump iOS version to 10.0 (Closed)

Created:
4 years, 1 month ago by kjellander_webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS: Cleanup buildbot JSON files + bump iOS version to 10.0 After https://chromium-review.googlesource.com/c/412190/ we can remove all the GYP variables. The GN args are also not used during runhooks (only GYP_DEFINES had any effect), so they're also removed to avoid confusion. Only use_goma=True was left since the ios recipe module uses it to decide if Goma shall be started on the bots. Delete unused GN/GYP-specific JSON files for bots that are now removed. Finally, bump iOS version 10.0 and change simulator phones to iPhone 6s to match what Chromium uses (may help solving bugs.webrtc.org/4752) BUG=webrtc:4752, webrtc:6323 NOTRY=True Committed: https://crrev.com/f880285af2d787ceb7c4aadfde21e0c27b21adde Cr-Commit-Position: refs/heads/master@{#15160}

Patch Set 1 #

Patch Set 2 : One more #

Patch Set 3 : Restored use_goma in gn_args #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -588 lines) Patch
M webrtc/build/ios/client.webrtc/iOS32_Debug.json View 1 2 1 chunk +5 lines, -18 lines 0 comments Download
M webrtc/build/ios/client.webrtc/iOS32_Release.json View 1 2 1 chunk +5 lines, -18 lines 0 comments Download
M webrtc/build/ios/client.webrtc/iOS32_Simulator_Debug.json View 1 2 1 chunk +8 lines, -21 lines 0 comments Download
M webrtc/build/ios/client.webrtc/iOS64_Debug.json View 1 2 1 chunk +5 lines, -18 lines 0 comments Download
D webrtc/build/ios/client.webrtc/iOS64_Debug_(GN).json View 1 chunk +0 lines, -34 lines 0 comments Download
D webrtc/build/ios/client.webrtc/iOS64_Debug_(GYP).json View 1 chunk +0 lines, -55 lines 0 comments Download
M webrtc/build/ios/client.webrtc/iOS64_Release.json View 1 2 1 chunk +5 lines, -18 lines 0 comments Download
D webrtc/build/ios/client.webrtc/iOS64_Release_(GN).json View 1 chunk +0 lines, -34 lines 0 comments Download
D webrtc/build/ios/client.webrtc/iOS64_Release_(GYP).json View 1 chunk +0 lines, -55 lines 0 comments Download
M webrtc/build/ios/client.webrtc/iOS64_Simulator_Debug.json View 1 2 1 chunk +8 lines, -21 lines 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios32_sim_dbg.json View 1 2 1 chunk +8 lines, -21 lines 0 comments Download
D webrtc/build/ios/tryserver.webrtc/ios64_gn_dbg.json View 1 chunk +0 lines, -35 lines 0 comments Download
D webrtc/build/ios/tryserver.webrtc/ios64_gn_rel.json View 1 chunk +0 lines, -35 lines 0 comments Download
D webrtc/build/ios/tryserver.webrtc/ios64_gyp_dbg.json View 1 chunk +0 lines, -56 lines 0 comments Download
D webrtc/build/ios/tryserver.webrtc/ios64_gyp_rel.json View 1 chunk +0 lines, -56 lines 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios64_sim_dbg.json View 1 2 1 chunk +8 lines, -21 lines 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios_arm64_dbg.json View 1 2 1 chunk +5 lines, -18 lines 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios_arm64_rel.json View 1 2 1 chunk +5 lines, -18 lines 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios_dbg.json View 1 2 1 chunk +5 lines, -18 lines 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios_rel.json View 1 2 1 chunk +5 lines, -18 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
kjellander_webrtc
4 years, 1 month ago (2016-11-18 12:04:26 UTC) #6
kthelgason
lgtm
4 years, 1 month ago (2016-11-21 08:11:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2507063008/40001
4 years, 1 month ago (2016-11-21 08:40:14 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-21 08:41:34 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 08:41:49 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f880285af2d787ceb7c4aadfde21e0c27b21adde
Cr-Commit-Position: refs/heads/master@{#15160}

Powered by Google App Engine
This is Rietveld 408576698