Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: webrtc/build/ios/client.webrtc/iOS32_Release.json

Issue 2507063008: iOS: Cleanup buildbot JSON files + bump iOS version to 10.0 (Closed)
Patch Set: Restored use_goma in gn_args Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/build/ios/client.webrtc/iOS32_Release.json
diff --git a/webrtc/build/ios/client.webrtc/iOS32_Release.json b/webrtc/build/ios/client.webrtc/iOS32_Release.json
index 411b2c381cb83b6683bcb5372823c8122532d401..3b8310fa588aacc317ca2b28c8133c50cc94f803 100644
--- a/webrtc/build/ios/client.webrtc/iOS32_Release.json
+++ b/webrtc/build/ios/client.webrtc/iOS32_Release.json
@@ -4,31 +4,18 @@
],
"comments": [
"Builder for 32-bit devices.",
- "GYP_DEFINES and gn_args in this file are only used during runhooks; ",
- "webrtc/build/mb_config.pyl decides the generated projects that are compiled."
+ "gn_args in this file is only read by the buildbot recipe; ",
+ "webrtc/build/mb_config.pyl contains the actual build configuration.",
+ "TODO(kjellander): remove gn_args when the recipe is updated."
],
"xcode version": "8.0",
- "GYP_DEFINES": [
- "use_goma=1",
- "gomadir=$(goma_dir)",
- "chromium_ios_signing=0",
- "component=static_library",
- "target_arch=arm"
- ],
"gn_args": [
- "is_debug=false",
- "target_os=\"ios\"",
- "ios_enable_code_signing=false",
- "is_component_build=false",
- "use_goma=true",
- "goma_dir=\"$(goma_dir)\"",
- "target_cpu=\"arm\""
+ "use_goma=true"
],
- "mb_type": "gn",
"compiler": "ninja",
"additional_compile_targets": [ "all" ],
"configuration": "Release",
- "sdk": "iphoneos9.0",
+ "sdk": "iphoneos10.0",
"tests": [
]
}
« no previous file with comments | « webrtc/build/ios/client.webrtc/iOS32_Debug.json ('k') | webrtc/build/ios/client.webrtc/iOS32_Simulator_Debug.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698