Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2506373004: RtpPacket::payload() return rtc::ArrayView instead of raw pointer (Closed)

Created:
4 years, 1 month ago by danilchap
Modified:
4 years, 1 month ago
Reviewers:
brandtr
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

RtpPacket::payload() return rtc::ArrayView instead of raw pointer BUG=webrtc:5261 Committed: https://crrev.com/96c1587551551b062ec9bd4617a3035c81a049d9 Cr-Commit-Position: refs/heads/master@{#15162}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -37 lines) Patch
M webrtc/modules/rtp_rtcp/source/flexfec_receiver.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 4 chunks +10 lines, -24 lines 1 comment Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
danilchap
4 years, 1 month ago (2016-11-18 10:07:37 UTC) #2
brandtr
lgtm https://codereview.webrtc.org/2506373004/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc File webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc (right): https://codereview.webrtc.org/2506373004/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc#newcode885 webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:885: EXPECT_THAT(sent_payload.subview(1), ElementsAreArray(payload)); Nice!
4 years, 1 month ago (2016-11-21 07:49:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2506373004/1
4 years, 1 month ago (2016-11-21 08:39:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/18763)
4 years, 1 month ago (2016-11-21 09:03:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2506373004/1
4 years, 1 month ago (2016-11-21 09:33:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 09:35:33 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 09:35:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96c1587551551b062ec9bd4617a3035c81a049d9
Cr-Commit-Position: refs/heads/master@{#15162}

Powered by Google App Engine
This is Rietveld 408576698