webrtc/modules/rtp_rtcp/source/rtp_sender.cc - Issue 2506373004: RtpPacket::payload() return rtc::ArrayView instead of raw pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender.cc

Issue 2506373004: RtpPacket::payload() return rtc::ArrayView instead of raw pointer (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_sender.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc

index 71ee0b600257d7619b733cdf5d7f0c07f5c34229..04c742651f789fb6f14f9adca6f88d9c9f74c46e 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc

@@ -1216,7 +1216,8 @@ std::unique_ptr<RtpPacketToSend> RTPSender::BuildRtxPacket(

ByteWriter<uint16_t>::WriteBigEndian(rtx_payload, packet.SequenceNumber());

// Add original payload data.

- memcpy(rtx_payload + kRtxHeaderSize, packet.payload(), packet.payload_size());

+ auto payload = packet.payload();

+ memcpy(rtx_payload + kRtxHeaderSize, payload.data(), payload.size());

return rtx_packet;

}