Changed the interface AudioMixer::RemoveSource to have a void return type.

Changed the interface AudioMixer::RemoveSource to have a void return type.

In the AudioMixerImpl implementation, removing a source never fails
and the return value is always true (see audio_mixer/audio_mixer_impl.cc).

A return value of |false| signaled that removing a source failed for
some reason. We have come to the conclusion that
   * we don't know how to handle a return value of |false|
   * we can't think of why an alternative implementation would need to
     signal failure when removing a stream.

To avoid having a status code that is never read, never acted upon and
probably never set to anything but |true|, we change ::RemoveSource to
not have a return value.

NOTRY=True
BUG=webrtc:6346
Committed: https://crrev.com/76b3049e7c0cb6ec1c7bb741a83f71a5e791fbaf
Cr-Commit-Position: refs/heads/master@{#15150}

[aleloi, 2016-11-17 18:04:54]

aleloi@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[aleloi, 2016-11-17 18:04:54]

Small one. Please take a look!

[aleloi, 2016-11-17 18:05:05]

Description was changed from

==========
Changed the interface AudioMixer::RemoveSource to have a void return type.

In the AudioMixerImpl implementation, removing a source never fails
and the return value is always true (see audio_mixer/audio_mixer_impl.cc).

A return value of |false| signaled that removing a source failed for
some reason. We have come to the conclusion that
   * we don't know how to handle a return value of |false|
   * we can't think of why an alternative implementation would need to
     signal failure when removing a stream.

To avoid having a status code that is never read, never acted upon and
probably never set to anything but |true|, we change ::RemoveSource to
not have a return value.

BUG=webrtc:6346
==========

to

==========
Changed the interface AudioMixer::RemoveSource to have a void return type.

In the AudioMixerImpl implementation, removing a source never fails
and the return value is always true (see audio_mixer/audio_mixer_impl.cc).

A return value of |false| signaled that removing a source failed for
some reason. We have come to the conclusion that
   * we don't know how to handle a return value of |false|
   * we can't think of why an alternative implementation would need to
     signal failure when removing a stream.

To avoid having a status code that is never read, never acted upon and
probably never set to anything but |true|, we change ::RemoveSource to
not have a return value.

NOTRY=True
BUG=webrtc:6346
==========

[kwiberg-webrtc, 2016-11-18 02:10:12]

lgtm, but see comment

https://codereview.webrtc.org/2506173003/diff/1/webrtc/api/audio/audio_mixer.h
File webrtc/api/audio/audio_mixer.h (right):

https://codereview.webrtc.org/2506173003/diff/1/webrtc/api/audio/audio_mixer....
webrtc/api/audio/audio_mixer.h:57: // on different threads.
It probably makes more sense to document these two separately now.

[aleloi, 2016-11-18 10:01:43]

The CQ bit was checked by aleloi@webrtc.org

[aleloi, 2016-11-18 10:01:44]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2506173003/#ps20001 (title:
"Updated doc comment for Add/Remove Source.")

[commit-bot: I haz the power, 2016-11-18 10:01:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-18 10:03:06]

Description was changed from

==========
Changed the interface AudioMixer::RemoveSource to have a void return type.

In the AudioMixerImpl implementation, removing a source never fails
and the return value is always true (see audio_mixer/audio_mixer_impl.cc).

A return value of |false| signaled that removing a source failed for
some reason. We have come to the conclusion that
   * we don't know how to handle a return value of |false|
   * we can't think of why an alternative implementation would need to
     signal failure when removing a stream.

To avoid having a status code that is never read, never acted upon and
probably never set to anything but |true|, we change ::RemoveSource to
not have a return value.

NOTRY=True
BUG=webrtc:6346
==========

to

==========
Changed the interface AudioMixer::RemoveSource to have a void return type.

In the AudioMixerImpl implementation, removing a source never fails
and the return value is always true (see audio_mixer/audio_mixer_impl.cc).

A return value of |false| signaled that removing a source failed for
some reason. We have come to the conclusion that
   * we don't know how to handle a return value of |false|
   * we can't think of why an alternative implementation would need to
     signal failure when removing a stream.

To avoid having a status code that is never read, never acted upon and
probably never set to anything but |true|, we change ::RemoveSource to
not have a return value.

NOTRY=True
BUG=webrtc:6346
==========

[commit-bot: I haz the power, 2016-11-18 10:03:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-18 10:03:16]

Description was changed from

==========
Changed the interface AudioMixer::RemoveSource to have a void return type.

In the AudioMixerImpl implementation, removing a source never fails
and the return value is always true (see audio_mixer/audio_mixer_impl.cc).

A return value of |false| signaled that removing a source failed for
some reason. We have come to the conclusion that
   * we don't know how to handle a return value of |false|
   * we can't think of why an alternative implementation would need to
     signal failure when removing a stream.

To avoid having a status code that is never read, never acted upon and
probably never set to anything but |true|, we change ::RemoveSource to
not have a return value.

NOTRY=True
BUG=webrtc:6346
==========

to

==========
Changed the interface AudioMixer::RemoveSource to have a void return type.

In the AudioMixerImpl implementation, removing a source never fails
and the return value is always true (see audio_mixer/audio_mixer_impl.cc).

A return value of |false| signaled that removing a source failed for
some reason. We have come to the conclusion that
   * we don't know how to handle a return value of |false|
   * we can't think of why an alternative implementation would need to
     signal failure when removing a stream.

To avoid having a status code that is never read, never acted upon and
probably never set to anything but |true|, we change ::RemoveSource to
not have a return value.

NOTRY=True
BUG=webrtc:6346

Committed: https://crrev.com/76b3049e7c0cb6ec1c7bb741a83f71a5e791fbaf
Cr-Commit-Position: refs/heads/master@{#15150}
==========

[commit-bot: I haz the power, 2016-11-18 10:03:17]

Patchset 2 (id:??) landed as
https://crrev.com/76b3049e7c0cb6ec1c7bb741a83f71a5e791fbaf
Cr-Commit-Position: refs/heads/master@{#15150}