Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2099)

Unified Diff: webrtc/api/audio/audio_mixer.h

Issue 2506173003: Changed the interface AudioMixer::RemoveSource to have a void return type. (Closed)
Patch Set: Updated doc comment for Add/Remove Source. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/audio_mixer/audio_mixer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/audio/audio_mixer.h
diff --git a/webrtc/api/audio/audio_mixer.h b/webrtc/api/audio/audio_mixer.h
index dbb58ca74a557018612ae3ee0538e7f7b304a77c..931f20eabaca3f5c263098c1c4d7396ce663555a 100644
--- a/webrtc/api/audio/audio_mixer.h
+++ b/webrtc/api/audio/audio_mixer.h
@@ -51,12 +51,13 @@ class AudioMixer : public rtc::RefCountInterface {
virtual ~Source() {}
};
- // Returns true if adding/removing was successful. A source is never
- // added twice and removal is never attempted if a source has not
- // been successfully added to the mixer. Addition and removal can
- // happen on different threads.
+ // Returns true if adding was successful. A source is never added
+ // twice. Addition and removal can happen on different threads.
virtual bool AddSource(Source* audio_source) = 0;
- virtual bool RemoveSource(Source* audio_source) = 0;
+
+ // Removal is never attempted if a source has not been successfully
+ // added to the mixer.
+ virtual void RemoveSource(Source* audio_source) = 0;
// Performs mixing by asking registered audio sources for audio. The
// mixed result is placed in the provided AudioFrame. This method
« no previous file with comments | « no previous file | webrtc/modules/audio_mixer/audio_mixer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698