Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2500373002: Configure FlexFEC in VideoQualityTest. (Closed)

Created:
4 years, 1 month ago by brandtr
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Configure FlexFEC in VideoQualityTest. Will be used by full stack tests and video_loopback. BUG=webrtc:5654 Committed: https://crrev.com/1293acae18cb4715b9848d97c9d6794fb7cfd621 Cr-Commit-Position: refs/heads/master@{#15114}

Patch Set 1 #

Patch Set 2 : Check pointer instead. #

Total comments: 3

Patch Set 3 : Feedback response 1. #

Patch Set 4 : Feedback response 2. #

Patch Set 5 : Actually create FlexfecReceiveStream in RunWithRenderers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -40 lines) Patch
M webrtc/video/full_stack.cc View 1 2 3 17 chunks +17 lines, -17 lines 0 comments Download
M webrtc/video/screenshare_loopback.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/video/video_loopback.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_quality_test.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/video/video_quality_test.cc View 1 2 3 4 10 chunks +53 lines, -21 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (11 generated)
brandtr
Check pointer instead.
4 years, 1 month ago (2016-11-15 11:29:16 UTC) #1
brandtr
Hey stefan and minyue, Please have a look at this change, which adds support for ...
4 years, 1 month ago (2016-11-15 11:30:38 UTC) #3
stefan-webrtc
lgtm % nit https://codereview.webrtc.org/2500373002/diff/20001/webrtc/video/video_quality_test.cc File webrtc/video/video_quality_test.cc (right): https://codereview.webrtc.org/2500373002/diff/20001/webrtc/video/video_quality_test.cc#newcode1073 webrtc/video/video_quality_test.cc:1073: flexfec_receive_config.flexfec_ssrc = kFlexfecSendSsrc; Set this to ...
4 years, 1 month ago (2016-11-15 11:52:32 UTC) #4
minyue-webrtc
lgtm % nit https://codereview.webrtc.org/2500373002/diff/20001/webrtc/video/full_stack.cc File webrtc/video/full_stack.cc (right): https://codereview.webrtc.org/2500373002/diff/20001/webrtc/video/full_stack.cc#newcode28 webrtc/video/full_stack.cc:28: foreman_cif.video = {true, 352, 288, 30, ...
4 years, 1 month ago (2016-11-15 12:16:58 UTC) #5
brandtr
https://codereview.webrtc.org/2500373002/diff/20001/webrtc/video/full_stack.cc File webrtc/video/full_stack.cc (right): https://codereview.webrtc.org/2500373002/diff/20001/webrtc/video/full_stack.cc#newcode28 webrtc/video/full_stack.cc:28: foreman_cif.video = {true, 352, 288, 30, 700000, 700000, 700000, ...
4 years, 1 month ago (2016-11-15 13:14:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2500373002/100001
4 years, 1 month ago (2016-11-16 09:01:30 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/16246)
4 years, 1 month ago (2016-11-16 09:11:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2500373002/100001
4 years, 1 month ago (2016-11-17 06:37:16 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 1 month ago (2016-11-17 06:47:34 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 06:47:43 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/1293acae18cb4715b9848d97c9d6794fb7cfd621
Cr-Commit-Position: refs/heads/master@{#15114}

Powered by Google App Engine
This is Rietveld 408576698