Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2499273002: Reduce full stack test time to 45 secs and add H264 and FlexFEC. (Closed)

Created:
4 years, 1 month ago by brandtr
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reduce full stack test time to 45 secs and add H264 and FlexFEC. This CL adds full stack tests that are used to measure the performance of H264 with and without FlexFEC. In order to not increase the bot run time, the CL also reduces the test time to 45 secs. This should be OK, since the BWE is faster to ramp up nowadays. Due to the test time change, there may be some performance alerts. BUG=webrtc:5654 Committed: https://crrev.com/dd369c6cc809e6f351a5bfa11a88847fb810aead Cr-Commit-Position: refs/heads/master@{#15118}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Enable FlexFEC test and reduce test time to 45 secs. #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -7 lines) Patch
M webrtc/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/video/full_stack.cc View 1 2 3 4 4 chunks +44 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
brandtr
Dito. Not sure if it is worth enabling the FlexFEC case on the bots, as ...
4 years, 1 month ago (2016-11-15 11:30:30 UTC) #2
brandtr
Rebase.
4 years, 1 month ago (2016-11-15 11:32:56 UTC) #3
stefan-webrtc
lgtm
4 years, 1 month ago (2016-11-15 11:59:03 UTC) #4
brandtr
Rebase.
4 years, 1 month ago (2016-11-15 12:09:32 UTC) #6
brandtr
Rebase.
4 years, 1 month ago (2016-11-15 13:16:41 UTC) #7
brandtr
Rebase.
4 years, 1 month ago (2016-11-16 08:58:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2499273002/100001
4 years, 1 month ago (2016-11-17 07:30:19 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 1 month ago (2016-11-17 07:57:00 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 07:57:08 UTC) #15
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/dd369c6cc809e6f351a5bfa11a88847fb810aead
Cr-Commit-Position: refs/heads/master@{#15118}

Powered by Google App Engine
This is Rietveld 408576698